Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating number can be entered as pod count #433

Closed
cheld opened this issue Feb 25, 2016 · 4 comments
Closed

Floating number can be entered as pod count #433

cheld opened this issue Feb 25, 2016 · 4 comments

Comments

@cheld
Copy link
Contributor

cheld commented Feb 25, 2016

Steps to reproduce
  1. Open deploy from settings
  2. enter 1.5 as number of pods
Observed result

no validation error

Expected result

validation error
@maciaszczykm
Copy link
Member

We should also add validation for big numbers here. I've just killed my cluster with 1 000 000 pods.

@maciaszczykm
Copy link
Member

Same for edit pod count action.

@bryk bryk added this to the v1.0 milestone Mar 1, 2016
@bryk
Copy link
Contributor

bryk commented Mar 1, 2016

Should be as easy as creating a validator that verifies that a number is an integer. 1.0? What do you think?

@floreks
Copy link
Member

floreks commented Mar 1, 2016

I'll take this one then

This was referenced Mar 1, 2016
Closed
Merged
@bryk bryk closed this as completed in #472 Mar 3, 2016
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this issue Sep 27, 2021
@kumarashit
Merge pull request kubernetes#433 from anvithks/delfinUI
6395940 
Added volumes and pool overview and list in tree view. Fixed kubernetes#424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bryk @floreks @maciaszczykm @cheld