Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended warning events recognition #424

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 25, 2016

I've added more partial strings indicating that event reason message is a warning or an error. It's based mostly on this file:
https://github.com/kubernetes/kubernetes/blob/53f0f9d59860131c2be301a0054adfc86e43945d/pkg/kubelet/container/event.go

Review on Reviewable

@codecov-io
Copy link

Current coverage is 81.52%

Merging #424 into master will not affect coverage as of 437a59e

@@            master    #424   diff @@
======================================
  Files           76      76       
  Stmts          617     617       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            503     503       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 437a59e

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Feb 25, 2016

One comment and :lgtm:


Reviewed 1 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


src/app/backend/eventscommon.go, line 31 [r1] (raw file):
outof - there is no such word?


Comments from the review on Reviewable.io

@floreks
Copy link
Member Author

floreks commented Feb 25, 2016

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


src/app/backend/eventscommon.go, line 31 [r1] (raw file):
It may not be a word but there is an event reason OutOfDisk so potentially there may be OutOfCPU OutOfSpace OutOfResources etc. It is only partial string.


Comments from the review on Reviewable.io

@bryk
Copy link
Contributor

bryk commented Feb 29, 2016

Reviewed 1 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/app/backend/eventscommon.go, line 31 [r1] (raw file):
:lgtm:


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Feb 29, 2016
Extended warning events recognition
@bryk bryk merged commit e1c2edb into kubernetes:master Feb 29, 2016
@bryk bryk deleted the card-status-fix branch February 29, 2016 13:11
anvithks added a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Added volumes and pool overview and list in tree view. Fixed kubernetes#424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants