Fix travis break #1388
Fix travis break #1388
Conversation
|
@olekzabl, @digitalfishpond, @maciaszczykm TIL: we run our tests on IE11, but not on Pull Requests, only on commits in master. Apparently my previous CL broke that. here a PR that fixes the tests the second commit in the PR is a quick hack to get the IE11 tests to run on this PR, I'm not sure if we can keep this change or not. I don't know the details of why we don't use this on all PRs but that might be a different discussion, so I'm more than happy to revert that one before merging. |
|
@rf232 In the past we had a lot of problems with flaky tests from sauce labs and we had to temporarily disable them on development branches. @bryk did the change in pull request #593, it might get you more insight. We can test if the issue with sauce labs flakes still occurs. Also +1 for first commit if Travis will pass. |
|
grmbl, now unittests work even in IE11, but somehow the protractor tests (integration tests) fail to start the browser now. |
rf232
force-pushed
the
fix-travis-break
branch
2 times, most recently
from
443b668 to
c7818c2
Compare
Current coverage is 93.74% (diff: 100%)@@ master #1388 diff @@
==========================================
Files 352 352
Lines 3022 3022
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2833 2833
Misses 189 189
Partials 0 0
|
|
run succeeded with ie11, removed second commit from pull request, ready for merging I think |
first commit fixes the break (hopefully, don't have IE11 around to test it :))
second commit enables the saucelabs to also run on pull requests, so we can see if this actually fixes the break