Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sauce access keys from travis config #593

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 30, 2016

With that tests on sauce will not run on devs' forks, which will
hopefully make them less flaky.

I've added the key to travis config variable and made publicly
available.

Partially addresses: #494


This change is Reviewable

@bryk
Copy link
Contributor Author

bryk commented Mar 30, 2016

@digitalfishpond Can you review?

@maciaszczykm
Copy link
Member

@bryk Denis will be back in the office next week.

With that tests on sauce will not run on devs' forks, which will
hopefully make them less flaky.

I've added the key to travis config variable and made publicly
availible.

Partially addresses: kubernetes#494
@bryk
Copy link
Contributor Author

bryk commented Mar 30, 2016

Oh yeah. I forgot. Can you review?

@codecov-io
Copy link

Current coverage is 86.89%

Merging #593 into master will not affect coverage as of 153d456

@@            master    #593   diff @@
======================================
  Files          102     102       
  Stmts          870     870       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            756     756       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 153d456

Powered by Codecov. Updated on successful CI builds.

@maciaszczykm
Copy link
Member

:lgtm:


Reviewed 1 of 1 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@maciaszczykm maciaszczykm merged commit 8dcf5a3 into kubernetes:master Mar 30, 2016
@maciaszczykm maciaszczykm mentioned this pull request Nov 3, 2016
@bryk bryk deleted the sauce-keys branch November 3, 2016 17:20
@bryk
Copy link
Contributor Author

bryk commented Nov 3, 2016

@rf232 Do you propose that we roll this back?

@rf232
Copy link
Contributor

rf232 commented Nov 3, 2016

It is a bit tricky that the pull requests have other tests than the merged
CL, but when I enabled all sauce tests the protractor tests gave some
problems so while I'd love to roll this back we should take a closer look
at it.

Rob

On Thu, Nov 3, 2016 at 6:21 PM, Piotr Bryk [email protected] wrote:

@rf232 https://github.com/rf232 Do you propose that we roll this back?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#593 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuJFsS4XJlskXHbqH3DgTXoStsOAasQks5q6hgEgaJpZM4H7ghV
.

@bryk
Copy link
Contributor Author

bryk commented Nov 3, 2016

I think as long as we're on saucelabs and travis this will be flaky. I hope that we'll be able to move to a dedicated jenkins in q1 that will solve the issues we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants