-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sauce access keys from travis config #593
Conversation
@digitalfishpond Can you review? |
@bryk Denis will be back in the office next week. |
With that tests on sauce will not run on devs' forks, which will hopefully make them less flaky. I've added the key to travis config variable and made publicly availible. Partially addresses: kubernetes#494
Oh yeah. I forgot. Can you review? |
Current coverage is
|
Reviewed 1 of 1 files at r1, 1 of 1 files at r3. Comments from the review on Reviewable.io |
@rf232 Do you propose that we roll this back? |
It is a bit tricky that the pull requests have other tests than the merged Rob On Thu, Nov 3, 2016 at 6:21 PM, Piotr Bryk [email protected] wrote:
|
I think as long as we're on saucelabs and travis this will be flaky. I hope that we'll be able to move to a dedicated jenkins in q1 that will solve the issues we have. |
With that tests on sauce will not run on devs' forks, which will
hopefully make them less flaky.
I've added the key to travis config variable and made publicly
available.
Partially addresses: #494
This change is