Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies 🌴 #554

Merged
merged 3 commits into from
Mar 25, 2016
Merged

Update all dependencies 🌴 #554

merged 3 commits into from
Mar 25, 2016

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello 👋

This is the first automated pull requests to help reach the goal of up to date and stable software.
It updates all of the dependencies in the package.json in one go, but from now on you’ll receive pull requests for each dependency update in isolation and in real time.

For updates that satisfy the existing version range you’ll get pull-requests only if it breaks your build.

Example:

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

When an update does not satisfy the existing range you’ll get the pull request right away.

Example:

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

Happy fixing and merging 🌴


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

This change is Reviewable

@bryk
Copy link
Contributor

bryk commented Mar 21, 2016

@floreks @maciaszczykm I managed to make greenkeeper work again. It should work from now on. Can you review this?

@maciaszczykm
Copy link
Member

I'll check it later.

@floreks
Copy link
Member

floreks commented Mar 21, 2016

Travis fails because of eslint plugin update.

Fix: eslint/eslint#4787 (comment)

Change

  "ecmaFeatures": {
    // Enable ES6 modules to have all language features covered.
    "modules": true,
  },

to

  parserOptions: {
      sourceType: "module"
  }

@bryk
Copy link
Contributor

bryk commented Mar 21, 2016

I believe you can push this change to this branch to fix this.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@floreks
Copy link
Member

floreks commented Mar 21, 2016

@bryk any idea how to add me to this PR?

@bryk
Copy link
Contributor

bryk commented Mar 21, 2016

I don't know.... Checking...

@bryk bryk added cla: yes and removed cla: no labels Mar 21, 2016
@bryk
Copy link
Contributor

bryk commented Mar 21, 2016

Don't mind the CLA bot. We can ignore it.

@codecov-io
Copy link

Current coverage is 86.54%

Merging #554 into master will not affect coverage as of 1215f60

@@            master    #554   diff @@
======================================
  Files           97      97       
  Stmts          847     847       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            733     733       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 1215f60

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Mar 21, 2016

Fixes #534

@floreks
Copy link
Member

floreks commented Mar 22, 2016

I've tested this and beside this 1 issue that is already fixed I haven't found any other issues.

:lgtm:


Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from the review on Reviewable.io

@bryk
Copy link
Contributor

bryk commented Mar 22, 2016

Ok, I'll retest this and merge if everything is fine.

@bryk
Copy link
Contributor

bryk commented Mar 22, 2016

Integration tests fail. Can you reverify?

@bryk bryk force-pushed the greenkeeper-update-all branch from f31caf2 to 2bfe1d4 Compare March 22, 2016 13:29
@bryk bryk force-pushed the greenkeeper-update-all branch from 2bfe1d4 to 949b5d5 Compare March 25, 2016 08:23
@bryk
Copy link
Contributor

bryk commented Mar 25, 2016

:lgtm:


Reviewed 1 of 1 files at r2, 1 of 1 files at r3, 5 of 5 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bryk bryk force-pushed the greenkeeper-update-all branch from 949b5d5 to 1215f60 Compare March 25, 2016 10:29
@bryk
Copy link
Contributor

bryk commented Mar 25, 2016

Merging.

@bryk bryk merged commit f9e1f9d into master Mar 25, 2016
@bryk bryk deleted the greenkeeper-update-all branch March 25, 2016 10:48
@bryk
Copy link
Contributor

bryk commented Mar 25, 2016

@floreks @maciaszczykm @digitalfishpond @cheld @olekzabl This is merged, please update your deps.

anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Fixed incorrect share and qtree status display. Added share overview to storage summary tree view widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants