-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dra-example-driver staging repo #7703
Create dra-example-driver staging repo #7703
Conversation
ee3ef38
to
a47e42b
Compare
a47e42b
to
4baba73
Compare
registry.k8s.io/manifests/k8s-staging-dra-example-driver/promoter-manifest.yaml
Show resolved
Hide resolved
4baba73
to
fd1fddb
Compare
fd1fddb
to
a689190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
pull-k8sio-cip failed, but with no information. Unrelated?
/assign @xmudrii For approval. |
/retest |
Seems so. I just re-ran the job and it passed. @xmudrii PTAL, thanks! |
Why do we want to promote artifacts for an example project ? IIUC it's an example for implementation of a DRA driver. |
@ameukam: the example driver is complete enough that it can be used to play around with DRA. We want to document how to use DRA and include real, functional examples. For that we need a DRA driver image. |
It's similar in this regard to the csi-driver-hostpath image. |
That makes sense, and thank you for directing users to registry.k8s.io rather than staging :-) |
That's correct. Please apply that diff |
a689190
to
8361210
Compare
Thanks! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an image pushing job at the test-infra repo next to the example I linked. https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-cloud-provider-kind.yaml
Keep spec.containers the same, but change all the other parameters to match the dra-example-driver repo
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upodroid I should be able to get to that next week. Thanks! |
This PR adds a staging repo to publish images built from https://github.com/kubernetes-sigs/dra-example-driver