Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dra-example-driver staging repo #7703

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jan 21, 2025

This PR adds a staging repo to publish images built from https://github.com/kubernetes-sigs/dra-example-driver

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jan 21, 2025
@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from ee3ef38 to a47e42b Compare January 21, 2025 19:00
@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from a47e42b to 4baba73 Compare January 21, 2025 19:02
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from 4baba73 to fd1fddb Compare January 22, 2025 17:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from fd1fddb to a689190 Compare January 23, 2025 17:34
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pull-k8sio-cip failed, but with no information. Unrelated?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2025
@pohly
Copy link
Contributor

pohly commented Jan 24, 2025

/assign @xmudrii

For approval.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jan 27, 2025

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jan 27, 2025

/lgtm

pull-k8sio-cip failed, but with no information. Unrelated?

Seems so. I just re-ran the job and it passed.

@xmudrii PTAL, thanks!

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Feb 3, 2025

@ameukam @dims Are you able to please take a quick look for approval?

@ameukam
Copy link
Member

ameukam commented Feb 10, 2025

Why do we want to promote artifacts for an example project ? IIUC it's an example for implementation of a DRA driver.

@pohly
Copy link
Contributor

pohly commented Feb 10, 2025

@ameukam: the example driver is complete enough that it can be used to play around with DRA. We want to document how to use DRA and include real, functional examples. For that we need a DRA driver image.

@pohly
Copy link
Contributor

pohly commented Feb 10, 2025

It's similar in this regard to the csi-driver-hostpath image.

@BenTheElder
Copy link
Member

@ameukam: the example driver is complete enough that it can be used to play around with DRA. We want to document how to use DRA and include real, functional examples. For that we need a DRA driver image.

That makes sense, and thank you for directing users to registry.k8s.io rather than staging :-)

@ameukam
Copy link
Member

ameukam commented Feb 12, 2025

@nojnhuh I think this approach is now outdated. we centralize the staging repos under the same project. See #7750

cc @upodroid

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Feb 12, 2025

@nojnhuh I think this approach is now outdated. we centralize the staging repos under the same project. See #7750

Thanks @ameukam! Does that entry in registries.tf only replace the change to infra/gcp/infra.yaml here currently? Everything else is still up to date with the current approach?

@upodroid
Copy link
Member

Thanks @ameukam! Does that entry in registries.tf only replace the change to infra/gcp/infra.yaml here currently? Everything else is still up to date with the current approach?

That's correct. Please apply that diff

@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from a689190 to 8361210 Compare February 12, 2025 21:11
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 12, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Feb 12, 2025

That's correct. Please apply that diff

Thanks! Done.

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an image pushing job at the test-infra repo next to the example I linked. https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-cloud-provider-kind.yaml

Keep spec.containers the same, but change all the other parameters to match the dra-example-driver repo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Feb 14, 2025

Please create an image pushing job at the test-infra repo next to the example I linked. https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-cloud-provider-kind.yaml

Keep spec.containers the same, but change all the other parameters to match the dra-example-driver repo

@upodroid I should be able to get to that next week. Thanks!

@k8s-ci-robot k8s-ci-robot merged commit d37383b into kubernetes:main Feb 14, 2025
4 of 5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 14, 2025
@nojnhuh nojnhuh deleted the dra-example-driver-project branch February 15, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants