Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image push job for dra-example-driver #34376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add image push job for dra-example-driver #34376

wants to merge 1 commit into from

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Feb 20, 2025

Follow-up from kubernetes/k8s.io#7703 (review)

/hold
The dra-example-driver repo doesn't have a cloudbuild.yaml yet, so I'll work on adding that before we merge this.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nojnhuh
Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 20, 2025
@nojnhuh nojnhuh force-pushed the dra-example-driver-image-push branch from a203c59 to 18839ea Compare February 20, 2025 16:13
@nojnhuh nojnhuh mentioned this pull request Feb 20, 2025
Open
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Feb 20, 2025

/hold
The dra-example-driver repo doesn't have a cloudbuild.yaml yet, so I'll work on adding that before we merge this.

This hold can be removed once kubernetes-sigs/dra-example-driver#77 merges.

@pohly
Copy link
Contributor

pohly commented Feb 21, 2025

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2025
@pohly
Copy link
Contributor

pohly commented Feb 21, 2025

/assign @cjwagner

For approval of image pushing job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@timwangmusic timwangmusic Awaiting requested review from timwangmusic

Assignees

@pohly pohly

@cjwagner cjwagner

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nojnhuh @k8s-ci-robot @pohly @cjwagner