Remove IsValidIP, IsValidCIDR & IsValidVLANTag #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove IsValidIP which can be replaced by https://godoc.org/gopkg.in/go-playground/validator.v9#hdr-Internet_Protocol_Address_IP
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 87.68% 87.11% -0.58%
==========================================
Files 7 7
Lines 203 194 -9
==========================================
- Hits 178 169 -9
Misses 16 16
Partials 9 9
Continue to review full report at Codecov.
|
John-Lin
reviewed
Jul 24, 2018
client/main.go
Outdated
| @@ -62,7 +64,8 @@ func main() { | |||
| } | |||
|
|
|||
| if setCIDR { | |||
| if !utils.IsValidCIDR(options.Interface.CIDR) { | |||
| errs := validate.Var(options.Interface.CIDR, "required,cidr") | |||
John-Lin
reviewed
Jul 24, 2018
client/main.go
Outdated
| @@ -84,8 +87,9 @@ func main() { | |||
| } | |||
|
|
|||
| if setRoute { | |||
| if !utils.IsValidCIDR(options.Route.DstCIDR) { | |||
| log.Fatalf("Route destination netIP is not correct: %s", options.Route.DstCIDR) | |||
| errs := validate.Var(options.Route.DstCIDR, "required,cidr") | |||
|
govendor fetch gopkg.in/go-playground/validator.v9 |
sufuf3
force-pushed
the
sufuf3/remove-IsValid
branch
from
fa35b61 to
50ed6be
Compare
sufuf3
force-pushed
the
sufuf3/remove-IsValid
branch
2 times, most recently
from
91859a1 to
97ce259
Compare
|
This PR can be used.
kubectl exec -it myapp-pod -- bash
$ kubectl get po
NAME READY STATUS RESTARTS AGE
myapp-pod 1/1 Running 0 1m
network-controller-server-tcp-2cp8x 1/1 Running 0 2h
network-controller-server-unix-dgr9c 1/1 Running 0 2h
root@myapp-pod:/# ifconfig
eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1450
inet 10.244.0.16 netmask 255.255.255.0 broadcast 0.0.0.0
ether 0a:58:0a:f4:00:10 txqueuelen 0 (Ethernet)
RX packets 45628 bytes 27987371 (27.9 MB)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 13848 bytes 752683 (752.6 KB)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
eth100: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
inet 192.168.24.50 netmask 255.255.255.0 broadcast 192.168.24.255
ether 7a:da:0b:c7:e9:3b txqueuelen 0 (Ethernet)
RX packets 8 bytes 648 (648.0 B)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 0 bytes 0 (0.0 B)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
lo: flags=73<UP,LOOPBACK,RUNNING> mtu 65536
inet 127.0.0.1 netmask 255.0.0.0
loop txqueuelen 1 (Local Loopback)
RX packets 0 bytes 0 (0.0 B)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 0 bytes 0 (0.0 B)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
root@myapp-pod:/# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
0.0.0.0 10.244.0.1 0.0.0.0 UG 0 0 0 eth0
10.244.0.0 0.0.0.0 255.255.255.0 U 0 0 0 eth0
10.244.0.0 10.244.0.1 255.255.0.0 UG 0 0 0 eth0
192.168.24.0 0.0.0.0 255.255.255.0 U 0 0 0 eth100
224.0.0.0 0.0.0.0 240.0.0.0 U 0 0 0 eth100
apiVersion: v1
kind: Pod
metadata:
name: myapp-pod
labels:
app: myapp
spec:
containers:
- name: myapp-container
image: ubuntu
command: ['sh', '-c', 'echo The app is running! && sleep 3600']
initContainers:
- name: init-network-client
image: sdnvortex/network-controller:sufuf3_remove-IsValid
command: ["/go/bin/client"]
args: ["-s=unix:///tmp/vortex.sock", "-b=br100", "-n=eth100", "-i=192.168.24.50/24", "--net=224.0.0.0/4", "-g=0.0.0.0"]
env:
- name: POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: POD_UUID
valueFrom:
fieldRef:
fieldPath: metadata.uid
volumeMounts:
- mountPath: /tmp/
name: grpc-sock
restartPolicy: Never
volumes:
- name: grpc-sock
hostPath:
path: /tmp/vortex/ |
sufuf3
force-pushed
the
sufuf3/remove-IsValid
branch
from
97ce259 to
0428718
Compare
sufuf3
changed the title
|
我後來思考一下還是覺得不要引入外部套件比較好XD 這樣專案比較不會太肥 |
|
好唷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://godoc.org/gopkg.in/go-playground/validator.v9#hdr-Internet_Protocol_Address_IP