-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route entity & update generateClientCommand #168
Conversation
src/entity/pod.go
Outdated
// PodRoute is the structure for add IP routing table | ||
type PodRoute struct { | ||
DstCIDR string `bson:"dstCIDR" json:"dstCIDR" validate:"required,cidr"` | ||
Gateway string `bson:"gateway" json:"gateway" validate:"min=1,max=4095"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min,max validate for string gateway ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, My bad. Fix soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max=4095,min=0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vlan part, update here linkernetworks/network-controller#67
Gateway use ip validate, this part was updated in this PR.
Codecov Report
@@ Coverage Diff @@
## develop #168 +/- ##
==========================================
- Coverage 77.95% 77.76% -0.2%
==========================================
Files 41 41
Lines 2005 2010 +5
==========================================
Hits 1563 1563
- Misses 333 337 +4
- Partials 109 110 +1
Continue to review full report at Codecov.
|
1eb63ed
to
370927f
Compare
370927f
to
3c55246
Compare
Dear All, please help me review this PR. |
3c55246
to
b1447bb
Compare
Rebase to latest develop branch. Done |
b1447bb
to
e0955da
Compare
e0955da
to
3392ab3
Compare
I have created a new branch(used the latest develop branch) & used format-patch & am do for this PR. * 3392ab3 Add add route in generateClientCommand, cc #154 sufuf3 2 hours ago
* a1f1459 Fix typo of PodVolume struct comment sufuf3 4 hours ago
* d3b7516 Add route entity, cc #154 sufuf3 4 hours ago
* bd21f12 Merge pull request #172 from linkernetworks/phstsai/VX-214 Che-Wei Lin 16 minutes ago
|\
| * d9486c6 improve unit test for query situation Pei Hsuan Tsai 3 hours ago
|/
* b0b2372 Change the response from bad-request to method not allowed hwchiu 5 hours ago
* deebf06 Use the kubeutil to check the pod status when deleteing the volume hwchiu 26 hours ago
* dc33188 Return the badrequest if the network still used by some Pods when delete the network hwchiu 26 hours ago
* 402f454 remove race John-Lin 3 hours ago |
Signed-off-by: sufuf3 <[email protected]>
Signed-off-by: sufuf3 <[email protected]>
For init container, add add route in generateClientCommand Signed-off-by: sufuf3 <[email protected]>
3392ab3
to
7649d3b
Compare
…struct Add route entity & update generateClientCommand
Related issue: #154
close #154