Merge pull request #112 from linkernetworks/johnlin/pod-entity-valida…

…te-fix johnlin/pod entity validate fix Former-commit-id: b0f1ff2fde2558b750e5bf19c6a4096f4fd8449e [formerly 9b7508a] Former-commit-id: 1b36e028d92f4fd1de2ea9ffcec645c6bd8b3b31
linkernetworks · Jul 18, 2018 · 76eefd3 · 76eefd3
2 parents c5f9d33 + 3c6bdc4
commit 76eefd3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/entity/pod.go b/src/entity/pod.go
@@ -13,7 +13,7 @@ const (
 type Container struct {
 	Name    string   `bson:"name" json:"name" validate:"required"`
 	Image   string   `bson:"image" json:"image" validate:"required"`
-	Command []string `bson:"command" json:"command" validate:"-"`
+	Command []string `bson:"command" json:"command" validate:"required,dive,required"`
 }
 
 type PodVolume struct {
@@ -25,10 +25,10 @@ type Pod struct {
 	ID         bson.ObjectId     `bson:"_id,omitempty" json:"id" validate:"-"`
 	Name       string            `bson:"name" json:"name" validate:"required"`
 	Namespace  string            `bson:"namespace" json:"namespace" validate:"required"`
-	Labels     map[string]string `bson:"labels,omitempty" json:"labels" validate:"-"`
+	Labels     map[string]string `bson:"labels,omitempty" json:"labels" validate:"required,dive,keys,alphanum,endkeys,required,alphanum"`
 	Containers []Container       `bson:"containers" json:"containers" validate:"required,dive,required"`
+	Volumes    []PodVolume       `bson:"volumes,omitempty" json:"volumes" validate:"required,dive,required"`
 	CreatedAt  *time.Time        `bson:"createdAt,omitempty" json:"createdAt,omitempty" validate:"-"`
-	Volumes    []PodVolume       `bson:"volumes,omitempty" json:"volumes" validate:"-"`
 }
 
 //GetCollection - get model mongo collection name.

diff --git a/src/server/handler_pod_test.go b/src/server/handler_pod_test.go
@@ -44,8 +44,7 @@ func (suite *PodTestSuite) SetupSuite() {
 	suite.wc.Add(service)
 }
 
-func (suite *PodTestSuite) TearDownSuite() {
-}
+func (suite *PodTestSuite) TearDownSuite() {}
 
 func TestPodSuite(t *testing.T) {
 	suite.Run(t, new(PodTestSuite))
@@ -64,7 +63,9 @@ func (suite *PodTestSuite) TestCreatePod() {
 	pod := entity.Pod{
 		Name:       tName,
 		Namespace:  namespace,
+		Labels:     map[string]string{},
 		Containers: containers,
+		Volumes:    []entity.PodVolume{},
 	}
 
 	bodyBytes, err := json.MarshalIndent(pod, "", "  ")