Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

johnlin/pod entity validate fix #112

Merged
merged 2 commits into from
Jul 18, 2018
Merged

johnlin/pod entity validate fix #112

merged 2 commits into from
Jul 18, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #112 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #112   +/-   ##
========================================
  Coverage    72.77%   72.77%           
========================================
  Files           35       35           
  Lines         1620     1620           
========================================
  Hits          1179     1179           
  Misses         379      379           
  Partials        62       62
Impacted Files Coverage Δ
src/server/handler_pod.go 73.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d6de2...83d9bd8. Read the comment docs.

@John-Lin
Copy link
Contributor Author

臨時捕的，沒有jira task主要針對validate tag做一些修正

hwchiu
hwchiu approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit 9b7508a into develop Jul 18, 2018
@hwchiu hwchiu deleted the johnlin/pod-entity-validate-fix branch July 18, 2018 05:12
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #112 from linkernetworks/johnlin/pod-entity-valida…
76eefd3 
…te-fix

johnlin/pod entity validate fix

Former-commit-id: b0f1ff2fde2558b750e5bf19c6a4096f4fd8449e [formerly 9b7508a]
Former-commit-id: 1b36e028d92f4fd1de2ea9ffcec645c6bd8b3b31
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #112 from linkernetworks/johnlin/pod-entity-valida…
4823428 
…te-fix

johnlin/pod entity validate fix

Former-commit-id: b0f1ff2fde2558b750e5bf19c6a4096f4fd8449e [formerly b0f1ff2fde2558b750e5bf19c6a4096f4fd8449e [formerly 9b7508a]]
Former-commit-id: 1b36e028d92f4fd1de2ea9ffcec645c6bd8b3b31
Former-commit-id: 76eefd3
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #112 from linkernetworks/johnlin/pod-entity-valida…
8265a23 
…te-fix

johnlin/pod entity validate fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@John-Lin @codecov-io @hwchiu @chenyunchen