Merge pull request #87 from linkernetworks/hwchiu/VX-111

Check the Pod when we delete the volume

Former-commit-id: 8bd9d4fc9803d6d80400a08651f4e3a2d5b5d198 [formerly 6758cf2]
Former-commit-id: df99e4fb65b85633f89bc150713c3fc6dd975c11

src/kubernetes/pods.go

@@ -33,3 +33,13 @@ func (kc *KubeCtl) DeletePod(name string) error {
 	options := metav1.DeleteOptions{}
 	return kc.Clientset.CoreV1().Pods(kc.Namespace).Delete(name, &options)
 }
+
+func (kc *KubeCtl) IsPodCompleted(pod *corev1.Pod) bool {
+	switch pod.Status.Phase {
+	case corev1.PodRunning, corev1.PodPending:
+		return false
+	default:
+		return true
+	}
+	return true
+}

src/kubernetes/pods_test.go

@@ -1,15 +1,22 @@
 package kubernetes
 
 import (
+	"math/rand"
 	"testing"
+	"time"
 
+	"github.com/moby/moby/pkg/namesgenerator"
 	"github.com/stretchr/testify/suite"
 
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	fakeclientset "k8s.io/client-go/kubernetes/fake"
 )
 
+func init() {
+	rand.Seed(time.Now().UnixNano())
+}
+
 type KubeCtlPodTestSuite struct {
 	suite.Suite
 	kubectl    *KubeCtl
@@ -77,6 +84,38 @@ func (suite *KubeCtlPodTestSuite) TestCreateDeletePod() {
 	suite.NoError(err)
 }
 
+func (suite *KubeCtlPodTestSuite) TestDoesPodCompleted() {
+	pods := []corev1.Pod{
+		{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: namesgenerator.GetRandomName(0),
+			},
+			Status: corev1.PodStatus{
+				Phase: corev1.PodPending,
+			},
+		},
+		{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: namesgenerator.GetRandomName(0),
+			},
+			Status: corev1.PodStatus{
+				Phase: corev1.PodSucceeded,
+			},
+		},
+	}
+
+	for _, pod := range pods {
+		_, err := suite.kubectl.CreatePod(&pod)
+		suite.NoError(err)
+	}
+
+	run := suite.kubectl.IsPodCompleted(&pods[0])
+	suite.False(run)
+
+	run = suite.kubectl.IsPodCompleted(&pods[1])
+	suite.True(run)
+}
+
 func (suite *KubeCtlPodTestSuite) TearDownSuite() {}
 
 func TestKubePodTestSuite(t *testing.T) {

src/volume/volume.go

@@ -1,6 +1,9 @@
 package volume
 
 import (
+	"fmt"
+	"strings"
+
 	"github.com/linkernetworks/mongo"
 	"github.com/linkernetworks/vortex/src/entity"
 	"github.com/linkernetworks/vortex/src/serviceprovider"
@@ -54,6 +57,32 @@ func CreateVolume(sp *serviceprovider.Container, volume *entity.Volume) error {
 }
 
 func DeleteVolume(sp *serviceprovider.Container, volume *entity.Volume) error {
-	name := volume.GetPVCName()
-	return sp.KubeCtl.DeletePVC(name)
+	//Check the pod
+	session := sp.Mongo.NewSession()
+	defer session.Close()
+
+	pods := []entity.Pod{}
+	err := session.FindAll(entity.PodCollectionName, bson.M{"volumes.name": volume.Name}, &pods)
+	if err != nil {
+		return fmt.Errorf("load the database fail:%v", err)
+	}
+
+	usedPod := []string{}
+	for _, pod := range pods {
+		//Check the pod's status, report error if at least one pod is running.
+		currentPod, err := sp.KubeCtl.GetPod(pod.Name)
+		if err != nil {
+			continue
+		}
+
+		if !sp.KubeCtl.IsPodCompleted(currentPod) {
+			usedPod = append(usedPod, pod.Name)
+		}
+	}
+	if len(usedPod) != 0 {
+		podNames := strings.Join(usedPod, ",")
+		return fmt.Errorf("delete the volume [%s] fail, since the followings pods still ust it: %s", volume.Name, podNames)
+	}
+
+	return sp.KubeCtl.DeletePVC(volume.GetPVCName())
 }

src/volume/volume_test.go

@@ -12,6 +12,9 @@ import (
 	"github.com/moby/moby/pkg/namesgenerator"
 	"github.com/stretchr/testify/suite"
 	"gopkg.in/mgo.v2/bson"
+
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
 func init() {
@@ -107,3 +110,68 @@ func (suite *VolumeTestSuite) TestCreateVolumeFail() {
 	err := CreateVolume(suite.sp, volume)
 	suite.Error(err)
 }
+
+func (suite *VolumeTestSuite) TestDeleteVolumeFail() {
+	volume := &entity.Volume{
+		ID:   bson.NewObjectId(),
+		Name: namesgenerator.GetRandomName(0),
+	}
+
+	session := suite.sp.Mongo.NewSession()
+	defer session.Close()
+
+	pods := []entity.Pod{
+		{
+			ID:   bson.NewObjectId(),
+			Name: namesgenerator.GetRandomName(0),
+			Volumes: []entity.PodVolume{
+				{
+					Name: volume.Name,
+				},
+			},
+		},
+		{
+			ID:   bson.NewObjectId(),
+			Name: namesgenerator.GetRandomName(0),
+			Volumes: []entity.PodVolume{
+				{
+					Name: volume.Name,
+				},
+			},
+		},
+	}
+
+	for _, pod := range pods {
+		session.Insert(entity.PodCollectionName, pod)
+		defer session.Remove(entity.PodCollectionName, "name", pod.Name)
+	}
+
+	//Create the pod via kubectl
+	suite.sp.KubeCtl.CreatePod(&corev1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: pods[0].Name,
+		},
+		Status: corev1.PodStatus{
+			Phase: corev1.PodRunning,
+		},
+	})
+	suite.sp.KubeCtl.CreatePod(&corev1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: pods[1].Name,
+		},
+		Status: corev1.PodStatus{
+			Phase: corev1.PodRunning,
+		},
+	})
+	suite.sp.KubeCtl.CreatePod(&corev1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: namesgenerator.GetRandomName(0),
+		},
+		Status: corev1.PodStatus{
+			Phase: corev1.PodRunning,
+		},
+	})
+
+	err := DeleteVolume(suite.sp, volume)
+	suite.Error(err)
+}