Check the Pod when we delete the volume #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #87 +/- ##
===========================================
+ Coverage 69.68% 71.89% +2.21%
===========================================
Files 32 33 +1
Lines 1260 1427 +167
===========================================
+ Hits 878 1026 +148
- Misses 324 333 +9
- Partials 58 68 +10
Continue to review full report at Codecov.
|
John-Lin
reviewed
Jul 12, 2018
src/kubernetes/pods.go
Outdated
| @@ -33,3 +33,13 @@ func (kc *KubeCtl) DeletePod(name string) error { | |||
| options := metav1.DeleteOptions{} | |||
| return kc.Clientset.CoreV1().Pods(kc.Namespace).Delete(name, &options) | |||
| } | |||
|
|
|||
| func (kc *KubeCtl) DoesPodCompleted(pod *corev1.Pod) bool { | |||
WakeupTsai
reviewed
Jul 13, 2018
src/volume/volume.go
Outdated
| pods := []entity.Pod{} | ||
| err := session.FindAll(entity.PodCollectionName, bson.M{"volumes.name": volume.Name}, &pods) | ||
| if err != nil { | ||
| return fmt.Errorf("Load the database fail:%v", err) |
There was a problem hiding this comment.
vscode都會建議 error message 不要大寫開頭，我們要統一嗎？
https://github.com/golang/go/wiki/CodeReviewComments#error-strings
John-Lin
approved these changes
Jul 13, 2018
chenyunchen
approved these changes
Jul 13, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Check the Pod when we delete the volume Former-commit-id: 8bd9d4fc9803d6d80400a08651f4e3a2d5b5d198 [formerly 6758cf2] Former-commit-id: df99e4fb65b85633f89bc150713c3fc6dd975c11
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Check the Pod when we delete the volume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoesPodCompletedwhich return false if the phase of Pod ispendingorrunning.