Merge pull request #299 from linkernetworks/phstsai/errorHandle

[Bug] Handle the errors when creating is failed
linkernetworks · Aug 30, 2018 · d73a8b0 · d73a8b0
2 parents 2caf621 + a572ca1
commit d73a8b0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/server/handler_deployment.go b/src/server/handler_deployment.go
@@ -56,6 +56,10 @@ func createDeploymentHandler(ctx *web.Context) {
 	if err := deployment.CreateDeployment(sp, &p); err != nil {
 		if errors.IsAlreadyExists(err) {
 			response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Deployment Name: %s already existed", p.Name))
+		} else if errors.IsConflict(err) {
+			response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting has conflict: %v", err))
+		} else if errors.IsInvalid(err) {
+			response.BadRequest(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting is invalid: %v", err))
 		} else {
 			response.InternalServerError(req.Request, resp.ResponseWriter, err)
 		}

diff --git a/src/server/handler_pod.go b/src/server/handler_pod.go
@@ -56,6 +56,10 @@ func createPodHandler(ctx *web.Context) {
 	if err := pod.CreatePod(sp, &p); err != nil {
 		if errors.IsAlreadyExists(err) {
 			response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Pod Name: %s already existed", p.Name))
+		} else if errors.IsConflict(err) {
+			response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting has conflict: %v", err))
+		} else if errors.IsInvalid(err) {
+			response.BadRequest(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting is invalid: %v", err))
 		} else {
 			response.InternalServerError(req.Request, resp.ResponseWriter, err)
 		}

diff --git a/src/server/handler_service.go b/src/server/handler_service.go
@@ -52,6 +52,10 @@ func createServiceHandler(ctx *web.Context) {
 	if err := service.CreateService(sp, &s); err != nil {
 		if errors.IsAlreadyExists(err) {
 			response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Service Name: %s already existed", s.Name))
+		} else if errors.IsConflict(err) {
+			response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting has conflict: %v", err))
+		} else if errors.IsInvalid(err) {
+			response.BadRequest(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting is invalid: %v", err))
 		} else {
 			response.InternalServerError(req.Request, resp.ResponseWriter, err)
 		}