Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle the errors when creating is failed #299

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@WakeupTsai WakeupTsai requested review from hwchiu and John-Lin August 30, 2018 09:45
@John-Lin John-Lin merged commit d73a8b0 into develop Aug 30, 2018
@codecov-io
Copy link

codecov-io commented Aug 30, 2018

Codecov Report

Merging #299 into develop will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
- Coverage    76.66%   76.41%   -0.26%     
===========================================
  Files           62       62              
  Lines         3596     3608      +12     
===========================================
  Hits          2757     2757              
- Misses         643      655      +12     
  Partials       196      196
Impacted Files Coverage Δ
src/server/handler_pod.go 66.93% <0%> (-2.24%) ⬇️
src/server/handler_service.go 68.59% <0%> (-2.35%) ⬇️
src/server/handler_deployment.go 66.93% <0%> (-2.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2caf621...a572ca1. Read the comment docs.

@John-Lin John-Lin deleted the phstsai/errorHandle branch August 31, 2018 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants