The restful handler of storageprovider #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
==========================================
+ Coverage 57.91% 60.8% +2.89%
==========================================
Files 12 13 +1
Lines 316 347 +31
==========================================
+ Hits 183 211 +28
- Misses 122 124 +2
- Partials 11 12 +1
Continue to review full report at Codecov.
|
hwchiu
changed the title
John-Lin
approved these changes
Jun 21, 2018
| ) | ||
|
|
||
| func CreateStorageProvider(ctx *web.Context) { | ||
| as, req, resp := ctx.ServiceProvider, ctx.Request, ctx.Response |
There was a problem hiding this comment.
we can use sp sp, req, resp
added 5 commits
June 22, 2018 14:59
For NFS, we should apply storageClass and deployment for provisioner. For GlusterFS, we should apply storageClass
hwchiu
changed the title
chenyunchen
approved these changes
Jun 23, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
The restful handler of storageprovider Former-commit-id: ca4d5444f048d8044919a23620a0b57da7fa9b22 [formerly e0f98bc] Former-commit-id: a7b69e7d4e8aff0b786d835c61c831b28377dfb5
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
The restful handler of storageprovider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage-provider is used to setup the storage for system and it should setup all resources we need for kubernetes (storageClass, storage-provisioner).