Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle the errors when creating is failed #299

Merged
merged 2 commits into from
Aug 30, 2018
Merged

[Bug] Handle the errors when creating is failed #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7b225d
error handle
WakeupTsai Aug 30, 2018
a572ca1
pod error handler
WakeupTsai Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/server/handler_deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ func createDeploymentHandler(ctx *web.Context) {
if err := deployment.CreateDeployment(sp, &p); err != nil {
if errors.IsAlreadyExists(err) {
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Deployment Name: %s already existed", p.Name))
} else if errors.IsConflict(err) {
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting has conflict: %v", err))
} else if errors.IsInvalid(err) {
response.BadRequest(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting is invalid: %v", err))
} else {
response.InternalServerError(req.Request, resp.ResponseWriter, err)
}
Expand Down
4 changes: 4 additions & 0 deletions src/server/handler_pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ func createPodHandler(ctx *web.Context) {
if err := pod.CreatePod(sp, &p); err != nil {
if errors.IsAlreadyExists(err) {
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Pod Name: %s already existed", p.Name))
} else if errors.IsConflict(err) {
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting has conflict: %v", err))
} else if errors.IsInvalid(err) {
response.BadRequest(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting is invalid: %v", err))
} else {
response.InternalServerError(req.Request, resp.ResponseWriter, err)
}
Expand Down
4 changes: 4 additions & 0 deletions src/server/handler_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ func createServiceHandler(ctx *web.Context) {
if err := service.CreateService(sp, &s); err != nil {
if errors.IsAlreadyExists(err) {
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Service Name: %s already existed", s.Name))
} else if errors.IsConflict(err) {
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting has conflict: %v", err))
} else if errors.IsInvalid(err) {
response.BadRequest(req.Request, resp.ResponseWriter, fmt.Errorf("Create setting is invalid: %v", err))
} else {
response.InternalServerError(req.Request, resp.ResponseWriter, err)
}
Expand Down