Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Forbid the namespace deleting if there is still some resource under it #320

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #320 into develop will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #320      +/-   ##
===========================================
- Coverage    71.37%   71.32%   -0.05%     
===========================================
  Files           66       66              
  Lines         4080     4087       +7     
===========================================
+ Hits          2912     2915       +3     
- Misses         937      940       +3     
- Partials       231      232       +1
Impacted Files Coverage Δ
src/server/handler_namespace.go 61.01% <0%> (-0.7%) ⬇️
src/namespace/namespace.go 85.71% <66.66%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f53b5...382d0af. Read the comment docs.

@John-Lin John-Lin merged commit 1471293 into develop Sep 20, 2018
@John-Lin John-Lin deleted the phstsai/namespaceDeleting branch September 20, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants