[Bug] Forbid the namespace deleting if there is still some resource under it

src/namespace/namespace.go

@@ -1,18 +1,22 @@
 package namespace
 
 import (
+	"fmt"
+
 	"github.com/linkernetworks/vortex/src/entity"
 	"github.com/linkernetworks/vortex/src/serviceprovider"
 
 	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime/schema"
 )
 
 // CreateNamespace will create namespace by serviceprovider container
 func CreateNamespace(sp *serviceprovider.Container, namespace *entity.Namespace) error {
 	n := corev1.Namespace{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:   namespace.Name,
+			Name: namespace.Name,
 		},
 	}
 	_, err := sp.KubeCtl.CreateNamespace(&n)
@@ -21,5 +25,14 @@ func CreateNamespace(sp *serviceprovider.Container, namespace *entity.Namespace)
 
 // DeleteNamespace will delete namespace
 func DeleteNamespace(sp *serviceprovider.Container, namespace *entity.Namespace) error {
+	deploys, err1 := sp.KubeCtl.GetDeployments(namespace.Name)
+	svcs, err2 := sp.KubeCtl.GetServices(namespace.Name)
+	pvcs, err3 := sp.KubeCtl.GetPVCs(namespace.Name)
+
+	//err from deployment/services/pvc should not return in namespace function
+	if (err1 == nil && err2 == nil && err3 == nil) && (len(deploys) != 0 || len(svcs) != 0 || len(pvcs) != 0) {
+		return errors.NewForbidden(schema.GroupResource{Group: "none", Resource: "Namespace"}, namespace.Name, fmt.Errorf("Still have some resource under namespace %v", namespace.Name))
+	}
+
 	return sp.KubeCtl.DeleteNamespace(namespace.Name)
 }

src/net/http/response.go

@@ -112,3 +112,8 @@ func MethodNotAllow(req *http.Request, resp http.ResponseWriter, errs ...error)
 func UnprocessableEntity(req *http.Request, resp http.ResponseWriter, errs ...error) (int, error) {
 	return WriteStatusAndError(req, resp, http.StatusUnprocessableEntity, errs...)
 }
+
+// NotAcceptable will set the status code http.StatusNotAcceptable to the HTTP response message
+func NotAcceptable(req *http.Request, resp http.ResponseWriter, errs ...error) (int, error) {
+	return WriteStatusAndError(req, resp, http.StatusNotAcceptable, errs...)
+}

src/server/handler_namespace.go

@@ -91,6 +91,8 @@ func deleteNamespaceHandler(ctx *web.Context) {
 	if err := namespace.DeleteNamespace(sp, &n); err != nil {
 		if errors.IsNotFound(err) {
 			response.NotFound(req.Request, resp.ResponseWriter, err)
+		} else if errors.IsForbidden(err) {
+			response.NotAcceptable(req.Request, resp.ResponseWriter, err)
 		} else {
 			response.InternalServerError(req.Request, resp.ResponseWriter, err)
 		}