support to get node IP #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #33 +/- ##
===========================================
+ Coverage 60.8% 62.32% +1.51%
===========================================
Files 13 14 +1
Lines 347 361 +14
===========================================
+ Hits 211 225 +14
Misses 124 124
Partials 12 12
Continue to review full report at Codecov.
|
hwchiu
reviewed
Jun 23, 2018
John-Lin
force-pushed
the
johnlin/get-nodeip
branch
from
1e7a421 to
2cc3c29
Compare
hwchiu
suggested changes
Jun 23, 2018
src/kubernetes/nodes_test.go
Outdated
| assert.NoError(t, err) | ||
| assert.Equal(t, 2, len(nodes)) | ||
| } | ||
|
|
||
| func (suite *KubeCtlTestSuite) TestGetNodeExternalIP(t *testing.T) { |
There was a problem hiding this comment.
Add the test case to get the non-existed node name
|
@hwchiu done |
|
why the coverage from 80% to 0%? src/kubernetes/nodes.go | 0% <0%> (-80%) |
|
fixed |
chenyunchen
approved these changes
Jun 23, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
support to get node IP Former-commit-id: e10f487bb051e4a26588eb088bfb9e4cb071e243 [formerly 1768230] Former-commit-id: 11226fca1172de15fb5c05546604809889a32da4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.