Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to get node IP #33

Merged
merged 6 commits into from
Jun 23, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/kubernetes/kubectl.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package kubernetes

import (
"k8s.io/client-go/kubernetes"
)

type KubeCtl struct {
Clientset kubernetes.Interface
Namespace string
}

func New(clientset kubernetes.Interface, namespace string) *KubeCtl {
return &KubeCtl{
Clientset: clientset,
Namespace: namespace,
}
}
26 changes: 19 additions & 7 deletions src/kubernetes/nodes.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,35 @@ package kubernetes
import (
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
)

func GetNode(clientset kubernetes.Interface, name string) (*corev1.Node, error) {
return clientset.CoreV1().Nodes().Get(name, metav1.GetOptions{})
func (kc *KubeCtl) GetNode(name string) (*corev1.Node, error) {
return kc.Clientset.CoreV1().Nodes().Get(name, metav1.GetOptions{})
}

func GetNodes(clientset kubernetes.Interface) ([]*corev1.Node, error) {
func (kc *KubeCtl) GetNodes() ([]*corev1.Node, error) {
nodes := []*corev1.Node{}
nodesList, err := clientset.CoreV1().Nodes().List(metav1.ListOptions{})
nodesList, err := kc.Clientset.CoreV1().Nodes().List(metav1.ListOptions{})
if err != nil {
return nodes, err
}

for _, n := range nodesList.Items {
nodes = append(nodes, &n)
}

return nodes, nil
}

func (kc *KubeCtl) GetNodeExternalIP(name string) (string, error) {
node, err := kc.GetNode(name)
if err != nil {
return "", err
}
var nodeIP string
for _, addr := range node.Status.Addresses {
if addr.Type == "ExternalIP" {
nodeIP = addr.Address
break
}
}
return nodeIP, nil
}
58 changes: 44 additions & 14 deletions src/kubernetes/nodes_test.go
Original file line number Diff line number Diff line change
@@ -1,56 +1,86 @@
package kubernetes

import (
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/suite"

corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
fakeclientset "k8s.io/client-go/kubernetes/fake"
"testing"
)

func TestGetNode(t *testing.T) {
type KubeCtlTestSuite struct {
suite.Suite
kubectl *KubeCtl
fakeclient fakeclientset.Clientset
}

func (suite *KubeCtlTestSuite) SetupTest() {
clientset := fakeclientset.NewSimpleClientset()
namespace := "default"
suite.kubectl = New(clientset, namespace)
}

func (suite *KubeCtlTestSuite) TestGetNode(t *testing.T) {
node := corev1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: "K8S-Node",
},
}
_, err := clientset.CoreV1().Nodes().Create(&node)
_, err := suite.fakeclient.CoreV1().Nodes().Create(&node)
assert.NoError(t, err)

result, err := GetNode(clientset, "K8S-Node")
result, err := suite.kubectl.GetNode("K8S-Node")
assert.NoError(t, err)
assert.Equal(t, node.GetName(), result.GetName())
}

func TestGetNodeFail(t *testing.T) {
clientset := fakeclientset.NewSimpleClientset()

_, err := GetNode(clientset, "UnKnown_Name")
func (suite *KubeCtlTestSuite) TestGetNodeFail(t *testing.T) {
_, err := suite.kubectl.GetNode("UnKnown_Name")
assert.Error(t, err)
}

func TestGetNodes(t *testing.T) {
clientset := fakeclientset.NewSimpleClientset()

func (suite *KubeCtlTestSuite) TestGetNodes(t *testing.T) {
node := corev1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: "K8S-Node1",
},
}
_, err := clientset.CoreV1().Nodes().Create(&node)
_, err := suite.fakeclient.CoreV1().Nodes().Create(&node)
assert.NoError(t, err)

node = corev1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: "K8S-Node2",
},
}
_, err = clientset.CoreV1().Nodes().Create(&node)
_, err = suite.fakeclient.CoreV1().Nodes().Create(&node)
assert.NoError(t, err)

nodes, err := GetNodes(clientset)
nodes, err := suite.kubectl.GetNodes()
assert.NoError(t, err)
assert.Equal(t, 2, len(nodes))
}

func (suite *KubeCtlTestSuite) TestGetNodeExternalIP(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the test case to get the non-existed node name

nodeAddr := corev1.NodeAddress{
Type: "ExternalIP",
Address: "192.168.0.100",
}
node := corev1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: "K8S-Node",
},
Status: corev1.NodeStatus{
Addresses: []corev1.NodeAddress{nodeAddr},
},
}
_, err := suite.fakeclient.CoreV1().Nodes().Create(&node)
assert.NoError(t, err)

nodeIP, err := suite.kubectl.GetNodeExternalIP("K8S-Node")
assert.NoError(t, err)
assert.Equal(t, nodeAddr.Address, nodeIP)
}
12 changes: 12 additions & 0 deletions vendor/vendor.json
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,18 @@
"revision": "f35b8ab0b5a2cef36673838d662e249dd9c94686",
"revisionTime": "2018-05-06T18:05:49Z"
},
{
"checksumSHA1": "wnEANt4k5X/KGwoFyfSSnpxULm4=",
"path": "github.com/stretchr/testify/require",
"revision": "f35b8ab0b5a2cef36673838d662e249dd9c94686",
"revisionTime": "2018-05-06T18:05:49Z"
},
{
"checksumSHA1": "uefllr2OtKBGo/kQSAPbW3w6p0A=",
"path": "github.com/stretchr/testify/suite",
"revision": "f35b8ab0b5a2cef36673838d662e249dd9c94686",
"revisionTime": "2018-05-06T18:05:49Z"
},
{
"checksumSHA1": "L1vKtjhZ2Lej0kfsLaTUm7ps/Yg=",
"path": "github.com/x-cray/logrus-prefixed-formatter",
Expand Down