Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the list function of storage Provider #36

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 23, 2018

  • For the storage provider, support the list function
  • Method: Get
  • use the page & page_size to change the data.

@codecov-io
Copy link

codecov-io commented Jun 23, 2018

Codecov Report

Merging #36 into develop will increase coverage by 0.59%.
The diff coverage is 84.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage    77.48%   78.07%   +0.59%     
===========================================
  Files           14       14              
  Lines          302      333      +31     
===========================================
+ Hits           234      260      +26     
- Misses          60       62       +2     
- Partials         8       11       +3
Impacted Files Coverage Δ
src/server/route.go 50% <100%> (+1.85%) ⬆️
src/server/handler_storage_provider.go 87.71% <84.37%> (-4.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253e7e4...e720227. Read the comment docs.

@hwchiu
Copy link
Contributor Author

hwchiu commented Jun 24, 2018

After merge #37 and this #36 , I will rewrite the testing to use the suite to avoid create same object(config/serviceprovider/restuful.container) many times and also fix the go_lint problem.

@hwchiu hwchiu merged commit b305193 into develop Jun 25, 2018
@hwchiu hwchiu deleted the hwchiu/VX-131 branch June 25, 2018 07:24
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Support the list function of storage Provider

Former-commit-id: 27d7d85e5f48eee4e78538aa7f9c50e38b8e2823 [formerly b305193]
Former-commit-id: 2b5bb42c943721cc6ea149463806f5bcc1576ad9
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Support the list function of storage Provider

Former-commit-id: 27d7d85e5f48eee4e78538aa7f9c50e38b8e2823 [formerly 27d7d85e5f48eee4e78538aa7f9c50e38b8e2823 [formerly b305193]]
Former-commit-id: 2b5bb42c943721cc6ea149463806f5bcc1576ad9
Former-commit-id: b88f569
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Support the list function of storage Provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants