Implement a restful to create the volume object. #37
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #37 +/- ##
============================================
+ Coverage 62.32% 75.05% +12.72%
============================================
Files 14 15 +1
Lines 361 477 +116
============================================
+ Hits 225 358 +133
+ Misses 124 105 -19
- Partials 12 14 +2
Continue to review full report at Codecov.
|
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/docker/docker/pkg/namesgenerator" |
There was a problem hiding this comment.
use github.com/moby/moby/pkg/namesgenerator
There was a problem hiding this comment.
Oh, I just copy the line here lol.
https://github.com/moby/moby/blob/master/pkg/namesgenerator/names-generator.go#L1
I will replace all from docker to moby in another PR.
Since all PR use the docker now (including the vendor.json).
src/server/handler_volume_test.go
Outdated
| assert.Equal(suite.T(), volume.Capacity, retVolume.Capacity) | ||
| assert.NotEqual(suite.T(), "", retVolume.MetaName) | ||
|
|
||
| //Empty daa |
There was a problem hiding this comment.
Empty data in the HTTP request and it will cause the read entity error.
There was a problem hiding this comment.
yeah, but I mean the comment has typo lol
src/server/handler_volume.go
Outdated
| // Check whether this displayname has been used | ||
| volume.ID = bson.NewObjectId() | ||
| volume.CreatedAt = timeutils.Now() | ||
| //Generate the metaName for furture use |
There was a problem hiding this comment.
I don't know what is furture? Did you mean future?
Thank you.
Implement a restful to create the volume object. Former-commit-id: f79b7be85c712cbadc137738f36a334bcb84b344 [formerly 004f168] Former-commit-id: 92e9310eacd956ac5b009d0991d46ec7be7ad6a3
Implement a restful to create the volume object.
An volume object is a PVC used for the container (Pod/Deployment) and it must belong to some exist stroageProvider