change : [M3-6471] - Add resource links to NodeBalancers empty state landing page. #10345
Conversation
cpathipa
requested review from
jdamore-linode and
jaalah-akamai
and removed request for
a team
cpathipa
changed the title
|
Coverage Report: ✅ |
There was a problem hiding this comment.
I'm glad this is getting an update!
Could we get Cypress test coverage for this change? NodeBalancer is really lacking in test coverage, and it would be great if we had something like a nodebalancers-empty-landing-page.spec.ts for this. (Like we have for domains, images, etc.)
- Confirmed that all links work and open the correct page.
- Confirmed there are no typos.
- Confirmed that Adobe Analytics events are firing on link click.
- Confirmed that empty state page looks good at all screen sizes. (Minus one minor thing noted as an edge case.)
Minor edge case: between widths of 350 and 368 (inclusive), the arrow wraps on the next line, if there's a quick styling fix for this.
Screen.Recording.2024-04-03.at.12.42.06.PM.mov
| @@ -11,6 +11,7 @@ interface ResourcesMoreLinkProps extends LinkProps { | |||
|
|
|||
| const StyledMoreLink = styled(Link)<ResourcesMoreLinkProps>(({ ...props }) => ({ | |||
| alignItems: props.external ? 'baseline' : 'center', | |||
| textWrap: 'balance', | |||
There was a problem hiding this comment.
The intent here is good to get the caret not to wrap by itself, unfortunately textWrap: 'balance' isn't very well supported and will (for instance) simply not work on safari.
one way to address it is to the same thing that was done for external links icons (negative margin + transform)
https://github.com/linode/manager/blob/develop/packages/manager/src/components/Link.styles.ts#L23-L26
There was a problem hiding this comment.
Thanks @abailly-akamai addressed in 68b9883
Description 📝
Add's resource links to NodeBalancers empty state landing page.
Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
Test coverage:
As an Author I have considered 🤔
Check all that apply