Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change : [M3-6471] - Add resource links to NodeBalancers empty state landing page. #10345
change : [M3-6471] - Add resource links to NodeBalancers empty state landing page. #10345
Changes from 6 commits
b6ed2e1
59f0ef1
55f5e3d
7e6a1ba
08dfe83
ae6a2c7
78a49ab
68b9883
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent here is good to get the caret not to wrap by itself, unfortunately
textWrap: 'balance'
isn't very well supported and will (for instance) simply not work on safari.one way to address it is to the same thing that was done for external links icons (negative margin + transform)
https://github.com/linode/manager/blob/develop/packages/manager/src/components/Link.styles.ts#L23-L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abailly-akamai addressed in 68b9883