Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7684] - Disable Volume Action Menu Buttons for Restricted Users #10641

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 3, 2024

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.

Here, we are disabling Volume Action Menu buttons when they do not have access or have read-only access.

Changes 🔄

  • For restricted users:
    • Disabled Volume Action Menu buttons (edit, resize, clone, detach, delete)
    • Disabled delete action menu will show a restricted user tooltip notice due to read-only access. Otherwise, it will show a restricted action notice if a Linode is attached.

Target release date 🗓️

July 8th, 2024

Preview 📷

Before_readonly_user_unattached_linode
Before_readonly_user_unattached_linode

After_readonly_user_unattached_linode.mov
Before_readonly_user_attached_linode.mov
After_readonly_user_attached_linode.mov

Note: Read-Write user access is same Before and After (Delete tooltip will show a restricted action notice if a Linode is attached)

Before_and_After_readwrite_user_attached_linode.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)
      - Start with Read Only for everything

Reproduction steps

  • Observe as restricted user:
    - Action Menu buttons will be disabled and will display their own corresponding tooltiptext notice message.

Verification steps

  • After the changes, observe that the action menu buttons and the tooltips are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 3, 2024 11:33
@pmakode-akamai pmakode-akamai requested review from dwiley-akamai and hana-akamai and removed request for a team July 3, 2024 11:33
Copy link

github-actions bot commented Jul 3, 2024

Coverage Report:
Base Coverage: 82.23%
Current Coverage: 82.23%

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! Volumes Relating to Volumes (aka Block Storage) labels Jul 3, 2024
@mjac0bs mjac0bs added the Restricted User Access Improve UX surrounding restricted access to features label Jul 3, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-7684-disable-volume-action-menu-buttons-for-restricted-users branch from 55097c9 to 5a81d35 Compare July 4, 2024 07:06
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled Volume action menu buttons (edit, resize, clone, detach, delete) for users with read-only permissions ✅

Disabled delete action menu shows a restricted action notice if a Linode is attached ✅

(verified the above for both the Volumes landing page and Linode Details > Storage > Volumes table)

Code review ✅

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 5, 2024
@pmakode-akamai pmakode-akamai merged commit ffa8162 into linode:develop Jul 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features Volumes Relating to Volumes (aka Block Storage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants