-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7684] - Disable Volume Action Menu Buttons for Restricted Users #10641
feat: [M3-7684] - Disable Volume Action Menu Buttons for Restricted Users #10641
Conversation
Coverage Report: ✅ |
55097c9
to
5a81d35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabled Volume action menu buttons (edit, resize, clone, detach, delete) for users with read-only permissions ✅
Disabled delete action menu shows a restricted action notice if a Linode is attached ✅
(verified the above for both the Volumes landing page and Linode Details > Storage > Volumes table)
Code review ✅
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
Here, we are disabling Volume Action Menu buttons when they do not have access or have read-only access.
Changes 🔄
read-only
access. Otherwise, it will show a restricted action notice if a Linode is attached.Target release date 🗓️
July 8th, 2024
Preview 📷
Before_readonly_user_unattached_linode

After_readonly_user_unattached_linode.mov
Before_readonly_user_attached_linode.mov
After_readonly_user_attached_linode.mov
Note:
Read-Write
user access is same Before and After (Delete tooltip will show a restricted action notice if a Linode is attached)Before_and_After_readwrite_user_attached_linode.mov
How to test 🧪
Prerequisites
(How to setup test environment)
- Start with
Read Only
for everythingReproduction steps
- Action Menu buttons will be disabled and will display their own corresponding tooltiptext notice message.
Verification steps
As an Author I have considered 🤔
Check all that apply