Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.124.0 - releasestaging #10691

Merged
merged 42 commits into from
Jul 22, 2024
Merged

Release v1.124.0 - releasestaging #10691

merged 42 commits into from
Jul 22, 2024

Conversation

carrillo-erik
Copy link
Contributor

@carrillo-erik carrillo-erik commented Jul 17, 2024

Cloud Manager

[2024-07-22] - v1.124.0

Added:

  • Account Limit support ticket form for limit errors in Linode Create flow (#10620)

Changed:

  • Use getRestrictedResourceText utility and move restrictions Notice to top of Volume Create (#10632)
  • Update Placement Group affinity labels and nomenclature (#10651)
  • Use new "lish" API instead of "lish_token" (#10656)
  • Display overflowing Kubernetes cluster tags in drawer (#10658)
  • Rename Distribution to OS (#10666)
  • Improve LKE Detail summary panel and Node Pool tables UI (#10685)
  • Disable Create Volume Button on the landing page for restricted users (#10627)
  • Disable Volume Action Menu buttons for restricted users (#10641)
  • Disable Create Volume button on empty state landing page for restricted users (#10630)
  • Disable Create Image button on empty state landing page for restricted users (#10670)
  • Disable Create Image button on landing page for restricted users (#10671)

Fixed:

  • Incorrect error notice in Volume drawers for restricted users (#10646)
  • Github CLI install link in Contributing guide (#10657)
  • LKE details page 'Delete Pool' button misalignment (#10660)
  • User Preferences not properly being cached when the app loads (#10663)
  • Blank toast notification when canceling an image upload (#10664)
  • Missing support link in some toast notifications (#10680)
  • Column headers for Automatic Images (#10696)

Removed:

  • Gravatar analytics events (#10661)

Tech Stories:

  • Improve getQueryParamsFromQueryString type safety (#10645)
  • Improve API flexibility for useToastNotification (#10654)
  • Clean up and fix Linode Details styles (#10662)
  • Improve PowerActionsDialog (#10667)
  • Replace Select with Autocomplete component on Kubernetes Create page (#10673)
  • Update Managed Queries to use Query Key Factory (#10679)

Tests:

  • Add Cypress integration test to add SSH key via Linode Create (#10448)
  • Add Cypress test for Login History page (#10575)
  • Add tests for Longview client rename and deletion (#10644)

Upcoming Features:

  • Add Tax ID Notifications & Warning Icon (#10558)
  • Add capability to save & retrieve user preferences (#10625)
  • Add feature flag and capability for OBJ Gen2 (#10647)
  • Add Analytics Events to Linode Create v2 (#10649)
  • Update Manage Image Regions drawer based on UX feedback (#10674)

API-v4

[2024-07-22] - v0.122.0

Changed:

  • Breaking: change Placement Group affinity_type to placement_group_type (#10651)
  • Breaking: change Placement Group is_strict to placement_group_policy (#10651)
  • Use new "lish" API instead of "lish_token" (#10656)

Upcoming Features:

  • Add ACLG Config and Widget to CloudPulse types (#10625)

Validation

[2024-07-22] - v0.50.0

Changed:

  • createAccountLimitSupportTicketSchema to support schemas (#10620)
  • Breaking: change Placement Group is_strict to placement_group_policy (#10651)

mjac0bs and others added 30 commits July 3, 2024 14:13
…nding Page for restricted users (#10627)

* feat: [M3-7684] - Disable Create Volume button with tooltiptext on Landing Page for restricted users

* Added changeset: Disabled Create Volume Button on the Landing Page for Restricted Users
…mpty State Landing Page' for Restricted Users (#10630)

* feat: [M3-7684] - Disable Create Volume button with tooltiptext on empty state Landing Page for restricted users

* Added changeset: Disabled Create Volume Button on the Empty State Landing Page for Restricted Users

* Add unit test for disable create btn on empty state landing page for restricted users

* Update changeset file
…ion Consistent (#10632)

* change: [M3-7684] - Keep Volumes Create Page Error Notification Position Consistent

* Added changeset: Position of error notif has been moved from inside the box to outside & used getRestrictedResourceText utility for the Notice

* Keep general error inside the paper

* Debugging fix

* Update changeset file
…sers (#10641)

* Disable volume action menu buttons for restricted users

* Disable inline action buttons for restricted users

* Added changeset: Disable Volume Action Menu buttons for restricted users

* refactor by adding attach and detach actions to actionType utils
…ted Users (#10646)

* Fix error notification notice on volume drawers

* Added changeset: Incorrect error notification notice on Volume Drawers

* Update changeset file
Release v1.123.0 - `staging` → `master`
* M3-8133 Add Cypress test for Login History page

* fixed comments

* Added changeset: Add Cypress test for Login History page
* send linode create event on creation

* add analytics for Create using command line

* Added changeset: Add Analytics Events to Linode Create v2

* pass form values insted of payload

* lint

* feedback @abailly-akamai

---------

Co-authored-by: Banks Nussman <[email protected]>
## Description 📝
Fix the github CLI link in our contributing guide leading to a 404 error

## How to test 🧪
### Reproduction steps
(How to reproduce the issue, if applicable)
- Go to the old link https://cli.github.com/manual/installation and notice a 404 error

### Verification steps
(How to verify changes)
- Go to the new link https://github.com/cli/cli#installation, there should not be a 404 error
* Clean up Gravatar analytics events

* Added changeset: Gravatar analytics events
…0660)

* Remove unnecessary bottom margin for the delete pool btn

* Added changeset: Fix LKE details page 'Delete Pool' button misalignment

* Update packages/manager/.changeset/pr-10660-fixed-1720504089793.md

Co-authored-by: Mariah Jacobs <[email protected]>

---------

Co-authored-by: Mariah Jacobs <[email protected]>
… user preferences (#10625)

* upcoming: [DI-19328] - Added capability to save & retrieve user preferences

* upcoming: [DI-19328] - Added capability to save & retrieve user preferences

* upcoming: [DI-19328] - Test cases added

* upcoming: [DI-19328] - Test cases updated

* Update packages/manager/.changeset/pr-10625-upcoming-features-1719830617170.md

Co-authored-by: Mariah Jacobs <[email protected]>

* upcoming: [DI-19328] - Remove empty select component from global filter components.

* upcoming: [DI-19328] - Fixed module importing issue

* DI-19328: Added ReactQuery in user preferences

* DI-19328: Added ReactQuery in user preferences

* DI-19328: Modified type of state variable in cloude pulse select

* upcoming: [DI-19328] - Improved naming conventions

---------

Co-authored-by: Mariah Jacobs <[email protected]>
…ty (#10645)

## Description 📝
Follow up to @jaalah's comment in #10479 about improving the type safety of getQueryParamsFromQueryString and removing the casting. The big diff is mostly from ESLint shuffling imports and code around

## Changes  🔄
List any change relevant to the reviewer.
- Type safe `getQueryParamsFromQueryString`
- Added `dom.iterable` to tsconfig.json

## How to test 🧪
### Verification steps
(How to verify changes)
- There should be no UI changes or regressions compared to prod
…Create (#10448)

* M3-7955 Cypress integration test to add SSH key via Linode Create

* Added changeset: Cypress integration test to add SSH key via Linode Create

* Fixed merge issue
…app loads (#10663)

* use query key factory for initial preferences fetch

* Added changeset: User Preferences not properly being cached when the app loads

* add back comment

---------

Co-authored-by: Banks Nussman <[email protected]>
* fix empty toast and incorrect wrapping

* make sure there is a message before showing

* Added changeset: Blank toast notification when canceling an image upload

* fix default toast

* actually fix default variant and light mode

* add a `maxWidth` on larger screens @jaalah-akamai

---------

Co-authored-by: Banks Nussman <[email protected]>
…10662)

* clean up and fix

* Added changeset: Clean up and fix Linode Details styles

* use `Paper` rather than `Box` @abailly-akamai

* replace some instances of `style` with `sx`

* use an action menu on small screens @hkhalil-akamai

---------

Co-authored-by: Banks Nussman <[email protected]>
…ow (#10658)

* Add overflow drawer for KubeSummaryPanel

* Fix bug causing "" is already added message

* Fix overflow button displaying with no tags

* Added changeset: Add drawer for overflowing tags in Kubernetes cluster details page

* Bundle TagDrawer with TagCell

* Feedback @dwiley-akamai

* Fix TagCell storybook

* Feedback @mjac0bs
## Description 📝
This change upgrades the backend weblish/glish session creation requests from the older `lish_token` API to a newer `lish` API. This newer API includes support for both core and distributed regions.

## Changes  🔄
List any change relevant to the reviewer.
- This change uses the new `lish` API which returns the full URLs rather than leaving it up to cloud manager to compute. For core regions, this should result in the same URL as cloud manager would have computed.
- The new `lish` API also returns values to use as WebSocket "protocols"; this will currently be an empty list for core regions, but include session information for distributed regions.

## How to test 🧪
Create weblish and glish sessions against a host. It should work exactly as before for core regions. In the browser Developer Tools, you should see accesses to the `lish` endpoint and _not_ the `lish_token` endpoint.

---------

Co-authored-by: Hana Xu <[email protected]>
…feedback (#10674)

* update to use new ux

* Added changeset: Update Manage Image Regions Drawer based on UX feedback

* fix obj regression

* update tests to reflect new UX

* add fallback

* fix placeholder behvaior

---------

Co-authored-by: Banks Nussman <[email protected]>
…ubernetes (#10673)

* refactor: [M3-6914] - Replace instances in: kubernetes

* Added changeset: Replace Select with Autocomplete in: kubernetes

* Add isOptionEqualToValue Prop to get rid of console warning

* Update changeset file

* Refactoring...

* Few more changes...
…pty state Landing Page for restricted users (#10670)

* feat: [M3-7683] - Disable Create Image button with tooltip text on empty state Landing Page for restricted users

* Added changeset: Disable Create Image button with tooltip text on empty state Landing Page for restricted users

* refactor: [M3-7683] - Correct the text for unit test of empty state landing page

* refactor: [M3-7683] Making variables more descriptive
…ding Page for restricted users (#10671)

* feat: [M3-7683] - Disable Create Image button with tooltiptext on Landing Page for restricted users

* Added changeset: Disable Create Image button with tooltiptext on Landing Page for restricted users

* refactor: [M3-7683] Making variables more descriptive
…low (#10620)

* Add new ticketType and create basic form

* Convert account limit fields to RHF

* Add placeholder text, helper text, and make entity field more generic

* Add account limit schema

* Move numberOfEntities to ProductSelectionFields

* Add default values and helper text

* Lint all the things that weren't linting when VSCode broke my linter

* Intercept account limit error in Linode Create flow

* Fix the diff

* Add test coverage for Account Limit support ticket

* Format description for account limit custom fields

* Update test

* Fix ticket submission error; correct order of form fields in test

* Clean up ticket title and component for support error notice

* Add support error to v2 flow

* Added changeset: Account Limit support ticket form for limit errors in Linode Create flow

* Clean up for consistency

* Address feedback: improve regex performance

* Address feedback: extract error message logic to component for reuse

* Add back missing variant caught by test failure

* Address feedback: fix entityType not being reset correctly

* Fix the CI failure
* refactor: [M3-8143] - Improve PowerActionsDialog

* Add helper text to the config select in Reboot Linode dialog

* Add changeset

* Fix failing unit test in LinodeResize

* Fix config select state for onClose() and onSubmit()

* Remove unnecessary clearable prop

* Fix broken test
@carrillo-erik carrillo-erik requested a review from a team as a code owner July 17, 2024 21:03
@carrillo-erik carrillo-erik requested review from cliu-akamai, hana-akamai and hkhalil-akamai and removed request for a team July 17, 2024 21:03
@carrillo-erik carrillo-erik self-assigned this Jul 17, 2024
@carrillo-erik carrillo-erik added the Release → Staging Pre-Release: Release → Staging label Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

Coverage Report:
Base Coverage: 82.23%
Current Coverage: 82.36%

* Reorder Size and Created headers

* Added changeset: Column headers for Automatic Images

* Update changelog and remove changeset
AzureLatte
AzureLatte previously approved these changes Jul 22, 2024
cpathipa
cpathipa previously approved these changes Jul 22, 2024
mjac0bs
mjac0bs previously approved these changes Jul 22, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs, package versions, and manual testing looked good. ✅

Approving pending CI finishes and is passing.

"version": "0.49.0",
"version": "0.50.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're missing the v0.50.0 changelog for validation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hana-linode I didn't see any changes in the changelog for validation so the version didn't get bumped. Are you seeing something different?

Copy link
Contributor

@mjac0bs mjac0bs Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hana-linode You're right. I forgot to add a changeset for the support ticket change. It should be:

---
"@linode/validation": Added
---
`createAccountLimitSupportTicketSchema` to support schemas ([#10620](https://github.com/linode/manager/pull/10620))

@carrillo-erik Sorry about the oversight.The other validation change is for placement_group_type and we should get that in there too. Can you update the changelog manually?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjac0bs Sure, don't worry about it. Both are part of the same PR, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the placement group one is from #10651. That will be a Changed entry in the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjac0bs Got it, I thought the image was from your PR. I figured it out and updated the changelog. Please review the edits. I'm going to bump the version on the validation package now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to bump the version because it already was bumped from 0.49.0 to 0.50.0, which is how Hana caught that we were missing the changesets. If the pkg version was bumped, we should have had at least one (in this case two) corresponding changelog update.

@carrillo-erik carrillo-erik dismissed stale reviews from mjac0bs, cpathipa, and AzureLatte via ed1fe44 July 22, 2024 16:46
@carrillo-erik carrillo-erik requested a review from mjac0bs July 22, 2024 16:53
@carrillo-erik carrillo-erik merged commit 5d69229 into staging Jul 22, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release → Staging Pre-Release: Release → Staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.