-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7683] - Disable Create Image button with tooltip text on empty state Landing Page for restricted users #10670
Conversation
…pty state Landing Page for restricted users
…ty state Landing Page for restricted users
Coverage Report: ✅ |
packages/manager/src/features/Images/ImagesLanding/ImagesLandingEmptyState.tsx
Outdated
Show resolved
Hide resolved
…ng-page-create-image-btn-for-restricted-users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @harsh-akamai - the disabled change for restricted users and the test coverage looks good.
We'll just want to delete the most recently added changeset.
packages/manager/.changeset/pr-10670-tech-stories-1721055859684.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Images/ImagesLanding/ImagesLandingEmptyState.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Harsh!
53fbc6c
to
298942b
Compare
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
Here, we are restricting users from creating new Image from the Empty State Landing Page when they do not have access or have read only access.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply