feat: [M3-8831] - New GPUv2 egress transfer display #11209

abailly-akamai · 2024-11-05T05:47:50Z

Description 📝

Small PR to implement conditional display of contextual help (banner + tooltip) of the new GPU ada plan split table.

Context: API will start returning 0 as trasnfer value for Ada plans

Changes 🔄

Fix the potential display of the 0 transfer value in the PlanSelection GPU panel
- 0 being falsy, it would display empty in the table
- 0 plan.transfer was also being filtered wrongly in PlanContainer
Add a new showTransferBanner boolean property to the gpuv2 feature flag
Add a Banner to the GPU plan selection panel
Add a tooltip to the GPU transfer table header
Add MSW data for helping review
Adjust e2e smokes

Target release date 🗓️

⚠️ 11/12/2024

Preview 📷

LD flag variations for reference:

How to test 🧪

Prerequisites

Verification steps

best to verify is using MSW legacy:
- displays 0 as expected
- features the new egress transfer banner
- features a new tooltip for the transfer column (only for gpu Ada plans)

As an Author I have considered 🤔

Check all that apply

abailly-akamai · 2024-11-05T06:44:23Z

packages/manager/src/features/components/PlansPanel/PlanContainer.styles.ts

@@ -20,6 +20,7 @@ export const StyledTableCell = styled(TableCell, {
  label: 'StyledTableCell',
  shouldForwardProp: omittedProps(['isPlanCell']),
 })<StyledTableCellPropsProps>(({ theme, ...props }) => ({
+  ...(props.isPlanCell && { width: '20%' }),


small fix to align the table cells better, tho more should be done eventually

Can you expand on what is meant by aligning the table cells? On my local, this causes undesirable overflowing in the plan cell:

develop This Branch

just aligning the label cells vertically between tables - i'll increase the size, or revert if it gets too out of scope.
Overflowing it not necessarily bad but I agree it can be improved here

fixed! thx for pointing this out, should be better now

packages/manager/src/features/components/PlansPanel/PlanSelection.tsx

packages/manager/src/features/components/PlansPanel/PlanInformation.tsx

coliu-akamai

I' feel like this might just be a me problem, but I toggled on and off the GPUv2 flag and now the double table isn't showing up 😅 I swear I didn't do anything else... 😅

(the flag is only returning gpuv2: true after I toggled it on and off, which I guess is why I'm not seeing the banner/divider)

(also very much unrelated to this PR, seeing that the tab for moving around the MSW window is a bit off)

Before that though, I was able to confirm:
✅ transfer column displays 0 + tooltip for ada plans
✅ egress banner
✅ plan-selection.spec.ts test passed

Saw there's no tooltip for the transfer section on smaller screen sizes - does the yellow banner about transfer plans covers it, since the tooltip for the column and the banner have similar text?

hkhalil-akamai · 2024-11-05T21:55:27Z

I' feel like this might just be a me problem, but I toggled on and off the GPUv2 flag and now the double table isn't showing up 😅 I swear I didn't do anything else... 😅

This is because the gpuV2 flag is an object, not boolean. Trying to change the value in DevTools coerces it into an invalid boolean.

packages/manager/src/dev-tools/FeatureFlagTool.tsx

hkhalil-akamai · 2024-11-05T22:02:01Z

packages/manager/src/features/components/PlansPanel/PlanContainer.styles.ts

@@ -20,6 +20,7 @@ export const StyledTableCell = styled(TableCell, {
  label: 'StyledTableCell',
  shouldForwardProp: omittedProps(['isPlanCell']),
 })<StyledTableCellPropsProps>(({ theme, ...props }) => ({
+  ...(props.isPlanCell && { width: '20%' }),


Can you expand on what is meant by aligning the table cells? On my local, this causes undesirable overflowing in the plan cell:

develop This Branch

github-actions · 2024-11-06T01:40:29Z

Coverage Report: ✅
Base Coverage: 87.47%
Current Coverage: 87.47%

coliu-akamai

✅ transfer column displays 0 + tooltip for ada plans
✅ egress transfer banner
✅ plan-selection.spec.ts test passed
✅ table spacing for plan names

👀 I am seeing an extra bar/table cell outline to the left of the plan column that wasn't there before though:

prod	this branch

jaalah-akamai · 2024-11-06T18:14:33Z

packages/manager/src/features/components/PlansPanel/PlanSelectionTable.tsx

    renderPlanSelection,
    shouldDisplayNoRegionSelectedMessage,
    showNetwork: shouldShowNetwork,
    showTransfer: shouldShowTransfer,
  } = props;
+  const flags = useFlags();
+
+  const showTransferTooltip = (cellName: string) =>


Nit: This feels like something that should be wrapped in useCallback

sure thing - done

also, @coliu-akamai good catch, fairly inconsequential but was able to keep parity with the latest commits

jaalah-akamai

Code looks good - and I was able to follow test instructions and see changes

linode-gh-bot · 2024-11-06T19:49:53Z

Cloud Manager UI test results

🎉 445 passing tests on test run #7 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`0 Failing`	`445 Passing`	`2 Skipped`	`88m 3s`

cypress · 2024-11-06T20:45:37Z

Cloud Manager E2E Run #6792

Run Properties: Passed #6792 • eeae3a3fd3: feat: [M3-8831] - New GPUv2 egress transfer display (#11209)

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Passed #6792`
Run duration	`26m 30s`
Commit	`eeae3a3fd3: feat: [M3-8831] - New GPUv2 egress transfer display (#11209)`
Committer	`Alban Bailly`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`2`
Pending	`2`
Skipped	`0`
Passing	`445`
View all changes introduced in this branch ↗︎

@coliu-akamai

* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (linode#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227) * fix: [M3-8764] - Kubernetes UI issues (linode#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (linode#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (linode#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (linode#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (linode#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236) * Make updates discussed to PR template during retro * Add changeset --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]>

@coliu-akamai

* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (linode#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227) * fix: [M3-8764] - Kubernetes UI issues (linode#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (linode#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (linode#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (linode#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (linode#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236) * Make updates discussed to PR template during retro * Add changeset * refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (linode#11254) * Move RadioGroup to ui package * Added changeset: Move `RadioGroup` from `manager` to `ui` package --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]>

@coliu-akamai

…ts for the Create Alert Definition Form (#11255) * Upcoming : [DI:21546] - Added the create button and name,description,severity components from General Information for the Create Alert Definition form * Upcoming: [DI:21456] - Added unit test for AlertSeverity component, changed the naming of properties in the Alert type, updated the url of endpoint * Upcoming: [DI:21546] - Added the unit test for CreateAlertDefinition component * upcoming: [DI:21546] - Added the onChange for the tabs * Upcoming: [DI-21546] - Removed unneccessary components and made changes to the Create Alert forma and Severity Select component * Upcoming: [DI-21694] - Modified the changes with Severity component, modified and added appropriate types * Upcoming: [DI-21694] - Added null as empty value for the Severity component, Fixed the Unit Tests for Severity component, fixed styling between components in Create Alert Form * Merging latest develop changes (#23) * feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (#11227) * fix: [M3-8764] - Kubernetes UI issues (#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (#11236) * Make updates discussed to PR template during retro * Add changeset --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]> * Revert "Merging latest develop changes (#23)" (#24) This reverts commit 2887f18. * Merging latest changes develop (#25) * feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (#11227) * fix: [M3-8764] - Kubernetes UI issues (#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (#11236) * Make updates discussed to PR template during retro * Add changeset * refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (#11254) * Move RadioGroup to ui package * Added changeset: Move `RadioGroup` from `manager` to `ui` package --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]> * upcoming: [DI-21694] - Added changesets * upcoming : [DI-21694] - Addressed the review comments * upcoming: [DI-21694] - Fixed the type safety issue for the AlertSeveritySelect component * upcoming: [DI-21694] - Fixed the dependency if Button component that was failing the test --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]>

Add new gpuV2 egress transferlogic

950167d

abailly-akamai self-assigned this Nov 5, 2024

abailly-akamai added 3 commits November 5, 2024 00:50

light cleanup

6a0f871

adjust e2e s

accd134

Added changeset: New GPUv2 egress transfer helpers

5f35fcd

abailly-akamai commented Nov 5, 2024

View reviewed changes

abailly-akamai marked this pull request as ready for review November 5, 2024 06:47

abailly-akamai requested review from a team as code owners November 5, 2024 06:47

abailly-akamai requested review from cliu-akamai, bnussman-akamai, harsh-akamai and coliu-akamai and removed request for a team November 5, 2024 06:47

coliu-akamai reviewed Nov 5, 2024

View reviewed changes

packages/manager/src/features/components/PlansPanel/PlanInformation.tsx Outdated Show resolved Hide resolved

coliu-akamai reviewed Nov 5, 2024

View reviewed changes

hkhalil-akamai reviewed Nov 5, 2024

View reviewed changes

feedback @coliu-akamai @hkhalil-akamai

b02c0cc

abailly-akamai requested review from hkhalil-akamai and coliu-akamai November 6, 2024 01:07

coliu-akamai approved these changes Nov 6, 2024

View reviewed changes

jaalah-akamai reviewed Nov 6, 2024

View reviewed changes

jaalah-akamai approved these changes Nov 6, 2024

View reviewed changes

abailly-akamai added 2 commits November 6, 2024 13:49

feedback @coliu-akamai @jaalah-akamai

3cfc91b

feedback optimization

0ef76b6

abailly-akamai merged commit eeae3a3 into linode:develop Nov 6, 2024
23 checks passed

jaalah-akamai mentioned this pull request Nov 7, 2024

Release v1.132.0 - release → staging #11220

Merged

abailly-akamai mentioned this pull request Nov 8, 2024

change: [M3-8866] - GPU egress transfer copy update #11235

Merged

12 tasks

hana-akamai mentioned this pull request Nov 12, 2024

Release v1.132.0 - staging → master #11249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-8831] - New GPUv2 egress transfer display #11209

feat: [M3-8831] - New GPUv2 egress transfer display #11209

abailly-akamai commented Nov 5, 2024 •

edited

Loading

abailly-akamai Nov 5, 2024

hkhalil-akamai Nov 5, 2024

abailly-akamai Nov 5, 2024

abailly-akamai Nov 6, 2024

coliu-akamai left a comment •

edited

Loading

hkhalil-akamai commented Nov 5, 2024

hkhalil-akamai Nov 5, 2024

github-actions bot commented Nov 6, 2024 •

edited

Loading

coliu-akamai left a comment

jaalah-akamai Nov 6, 2024

abailly-akamai Nov 6, 2024

jaalah-akamai left a comment

linode-gh-bot commented Nov 6, 2024

cypress bot commented Nov 6, 2024

feat: [M3-8831] - New GPUv2 egress transfer display #11209

feat: [M3-8831] - New GPUv2 egress transfer display #11209

Conversation

abailly-akamai commented Nov 5, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coliu-akamai left a comment • edited Loading

Choose a reason for hiding this comment

hkhalil-akamai commented Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 6, 2024 • edited Loading

coliu-akamai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaalah-akamai left a comment

Choose a reason for hiding this comment

linode-gh-bot commented Nov 6, 2024

Cloud Manager UI test results

🎉 445 passing tests on test run #7 ↗︎

cypress bot commented Nov 6, 2024

abailly-akamai commented Nov 5, 2024 •

edited

Loading

coliu-akamai left a comment •

edited

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading