Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8193] - Tooltip for Create/Resize Database table #11223

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Nov 7, 2024

Description πŸ“

Tooltip for Create/Resize Database table

Changes πŸ”„

  • Added 'Usable Storage' with tooltip to the Create/Resize Database Table.

Target release date πŸ—“οΈ

11/12/24

Preview πŸ“·

Before After
Screenshot 2024-11-07 at 12 44 11β€―PM Screenshot 2024-11-07 at 12 44 41β€―PM

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Managed Databases account capability
  • dbaasV2 feature flag set to GA

Verification steps

(How to verify changes)

  • Navigate to the Create Database Cluster page
  • Navigate to the Resize Database Tab

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner November 7, 2024 11:49
@mpolotsk-akamai mpolotsk-akamai requested review from mjac0bs and hkhalil-akamai and removed request for a team November 7, 2024 11:49
Copy link

github-actions bot commented Nov 7, 2024

Coverage Report: βœ…
Base Coverage: 87.37%
Current Coverage: 87.37%

@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-8193-Tooltip-for-Create-Database branch from 801851c to 8fd4cc8 Compare November 7, 2024 13:08
@coliu-akamai coliu-akamai added the DBaaS Relates to Database as a Service label Nov 7, 2024
@mjac0bs
Copy link
Contributor

mjac0bs commented Nov 7, 2024

Same question as Banks goes for here as well:

Heads up the release branch for our 11/12 release has already been cut. How urgent is this?

@cpathipa cpathipa requested review from cpathipa and removed request for hkhalil-akamai November 7, 2024 18:22
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this after confirming the tooltip appears where it should in the table and tests pass.

I don't think this is an urgent change to get into the already-cut release and so the target date should be updated to 12/10, but will let others including the FE fire chief determine that.

I left some comments about accessibility and mobile view for consideration.

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming on tooltip on resize tab.
image

@mjac0bs mjac0bs added Add'tl Approval Needed Waiting on another approval! Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 7, 2024
@cpathipa
Copy link
Contributor

cpathipa commented Nov 7, 2024

Agreed with @mjac0bs point, it would be nice to provide consistent context for small screens as well.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested given UX feedback.

@mjac0bs mjac0bs added Requires Changes and removed Approved Multiple approvals and ready to merge! labels Nov 7, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking in with Kendall and addressing feedback, @mpolotsk-akamai ! The change for smaller screen sizes looks good to me.

Screenshot 2024-11-08 at 8 51 28β€―AM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Requires Changes labels Nov 8, 2024
@jaalah-akamai jaalah-akamai changed the base branch from develop to release-v1.132.0 November 8, 2024 17:11
@jaalah-akamai jaalah-akamai changed the base branch from release-v1.132.0 to develop November 8, 2024 17:11
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 445 passing tests on test run #6 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing445 Passing2 Skipped95m 43s

@jaalah-akamai jaalah-akamai merged commit 27a651c into linode:develop Nov 8, 2024
23 checks passed
Copy link

cypress bot commented Nov 8, 2024

Cloud Manager E2EΒ  Β  Run #6804

Run Properties:Β  status check failedΒ FailedΒ #6804 Β β€’Β  git commit 27a651cae7: feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223)
Project Cloud Manager E2E
Branch Review develop
Run status status check failedΒ FailedΒ #6804
Run duration 30m 27s
Commit git commit 27a651cae7: feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223)
Committer mpolotsk-akamai
View all properties for this run β†—οΈŽ

Test results
Tests that failedΒ  Failures 1
Tests that were flakyΒ  Flaky 4
Tests that did not run due to a developer annotating a test with .skipΒ  Pending 2
Tests that did not run due to a failure in a mocha hookΒ  Skipped 0
Tests that passedΒ  Passing 444
View all changes introduced in this branch β†—οΈŽ

Tests for review

FailedΒ  cypress/e2e/core/linodes/clone-linode.spec.ts β€’ 1 failed test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
FlakinessΒ  cypress/e2e/core/databases/resize-database.spec.ts β€’ 4 flaky tests

View Output Video

Test Artifacts
Resizing existing clusters > Resizes a g6-standard-6 MySQL v8.x 3-node cluster > Can resize active database clusters Screenshots Video
Resizing existing clusters > Resizes a g6-standard-6 MySQL v8.x 3-node cluster > Can resize active database clusters from g6-standard-6 type and switch plan type Screenshots Video
Resizing existing clusters > Resizes a g6-dedicated-16 MySQL v5.x 3-node cluster > Can resize active database clusters Screenshots Video
Resizing existing clusters > Resizes a g6-dedicated-16 MySQL v5.x 3-node cluster > Can resize active database clusters from g6-dedicated-16 type and switch plan type Screenshots Video

santoshp210-akamai added a commit to santoshp210-akamai/manager that referenced this pull request Nov 13, 2024
* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199)

* feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209)

* Add new gpuV2 egress transferlogic

* light cleanup

* adjust e2e s

* Added changeset: New GPUv2 egress transfer helpers

* feedback @coliu-akamai @hkhalil-akamai

* feedback @coliu-akamai @jaalah-akamai

* feedback optimization

* change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206)

## Description πŸ“
In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled

Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did

## Changes  πŸ”„
List any change relevant to the reviewer.
- Disable unsupported images/distros for distributed regions in Linode Create
- Removed the distributed icon & associated icon text
- Removed the word `currently` in the Add-Ons warning notice for distributed regions
- Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component

## Target release date πŸ—“οΈ
11/12

## How to test πŸ§ͺ

### Prerequisites
(How to setup test environment)
- Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags

### Verification steps
(How to verify changes)
- Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab:
  - Select a core region -> No Images/distributions should be disabled
  - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled
- There should be no regressions in the components that were refactored
- Ensure unit tests and e2e tests are passing locally/remotely

* fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218)

* feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178)

* feat: [M3-8528] - Include Object Storage in Support Tickets

* query change

* Added changeset: Include Object Storage buckets in Support tickets dropdown

* added link support for object storage

* removed redundant query

* query updation and restructuring request payload

* Added changeset

* Initial Changelog

* refactor: [M3-8646] – Migrate `Divider` to `ui` package  (linode#11205)

* refactor: [M3-8646] – Migrate `Divider` to `ui` package

* Added changeset: Migrate Divider to ui package

* migrating all  imports

* removing redundant hook imports

* updated the import for omittedProps

* UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227)

* fix: [M3-8764] - Kubernetes UI issues (linode#11217)

* initial clean up

* save progress

* add changeset

* fix type error

* feedback @mjac0bs

* a few more small fixes

* a few more small fixes

---------

Co-authored-by: Banks Nussman <[email protected]>

* upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225)

* upcoming: [DI-18419] - chart post processing for missing timestamps

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Added changeset

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - early returns for empty array

---------

Co-authored-by: vmangalr <[email protected]>

* Update changelog

* refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228)

* migrate stack, update organization for divider/icon button

* Added changeset: `Stack` component to `ui` package

* refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174)

* Move Notice to UI package and update imports

* Add test imports

* Add renderWithTheme and other changes to make tests pass

* Fix broken icon imports

* Added changeset: Move `Notice` and `Tooltip` components to UI package

* Feedback @dwiley-akamai: consolidate imports and rename icon exports

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172)

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object.

* Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object.

* Update changeset description

Co-authored-by: Purvesh Makode <[email protected]>

* remove optional chaining

* change Text from "Subnets" to "Subnet"

* remove extra borderTop

* refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object

* Add descriptive variable name

---------

Co-authored-by: Purvesh Makode <[email protected]>

* upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226)

* upcoming: [DI-21814] - DBaaS instances order by label

* upcoming: [DI-21814] - Added changeset

* DI-21814: use map for better readability and optimisations

---------

Co-authored-by: vmangalr <[email protected]>

* UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231)

* feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* feat: [UIE-8193] - Tooltip context for small screens

* feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table

* feat: [UIE-8193] - Tooltip context for small screens

* DBaaS additions

* GPU egress transfer copy update (linode#11235)

* default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234)

Co-authored-by: Talmai Oliveira <[email protected]>

* Update PULL_REQUEST_TEMPLATE.md (linode#11219)

* change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221)

* Update 08-testing.md for userEvent

* Fix typo

* Address feedback; also further clean up linting issues the doc

* Fix a bad test that was not following good practices

* Added changeset: Update developer docs on unit testing user events

* Update changelog

* Fix LKE create ACL tests (linode#11237)

* feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179)

* feat: [M3-8665] - add option to copy token in LKE details page.

* Added changeset: option to copy token in LKE details page

* Change the "Copy Token" button to use asynchronous functionality

* remove extra styling

* refactor: [M3-8665] - add option to copy token in LKE details page.

* Change cypress test for LKE update spec

* fix: sx styling for Textfield component (linode#11246)

* spread containerProps sx

* spread props.sx as well whoops

* fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247)

* don't fetch when `type` is an empty string

* fix and changelog entry

---------

Co-authored-by: Banks Nussman <[email protected]>

* change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236)

* Make updates discussed to PR template during retro

* Add changeset

---------

Co-authored-by: corya-akamai <[email protected]>
Co-authored-by: Alban Bailly <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
Co-authored-by: Harsh Shankar Rao <[email protected]>
Co-authored-by: Jaalah Ramos <[email protected]>
Co-authored-by: rodonnel-akamai <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: venkatmano-akamai <[email protected]>
Co-authored-by: vmangalr <[email protected]>
Co-authored-by: Connie Liu <[email protected]>
Co-authored-by: Hussain Khalil <[email protected]>
Co-authored-by: hasyed-akamai <[email protected]>
Co-authored-by: Purvesh Makode <[email protected]>
Co-authored-by: ankitaakamai <[email protected]>
Co-authored-by: mpolotsk-akamai <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: John Callahan <[email protected]>
Co-authored-by: Mariah Jacobs <[email protected]>
Co-authored-by: jdamore-linode <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
santoshp210-akamai added a commit to santoshp210-akamai/manager that referenced this pull request Nov 13, 2024
* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199)

* feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209)

* Add new gpuV2 egress transferlogic

* light cleanup

* adjust e2e s

* Added changeset: New GPUv2 egress transfer helpers

* feedback @coliu-akamai @hkhalil-akamai

* feedback @coliu-akamai @jaalah-akamai

* feedback optimization

* change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206)

## Description πŸ“
In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled

Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did

## Changes  πŸ”„
List any change relevant to the reviewer.
- Disable unsupported images/distros for distributed regions in Linode Create
- Removed the distributed icon & associated icon text
- Removed the word `currently` in the Add-Ons warning notice for distributed regions
- Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component

## Target release date πŸ—“οΈ
11/12

## How to test πŸ§ͺ

### Prerequisites
(How to setup test environment)
- Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags

### Verification steps
(How to verify changes)
- Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab:
  - Select a core region -> No Images/distributions should be disabled
  - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled
- There should be no regressions in the components that were refactored
- Ensure unit tests and e2e tests are passing locally/remotely

* fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218)

* feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178)

* feat: [M3-8528] - Include Object Storage in Support Tickets

* query change

* Added changeset: Include Object Storage buckets in Support tickets dropdown

* added link support for object storage

* removed redundant query

* query updation and restructuring request payload

* Added changeset

* Initial Changelog

* refactor: [M3-8646] – Migrate `Divider` to `ui` package  (linode#11205)

* refactor: [M3-8646] – Migrate `Divider` to `ui` package

* Added changeset: Migrate Divider to ui package

* migrating all  imports

* removing redundant hook imports

* updated the import for omittedProps

* UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227)

* fix: [M3-8764] - Kubernetes UI issues (linode#11217)

* initial clean up

* save progress

* add changeset

* fix type error

* feedback @mjac0bs

* a few more small fixes

* a few more small fixes

---------

Co-authored-by: Banks Nussman <[email protected]>

* upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225)

* upcoming: [DI-18419] - chart post processing for missing timestamps

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Added changeset

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - early returns for empty array

---------

Co-authored-by: vmangalr <[email protected]>

* Update changelog

* refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228)

* migrate stack, update organization for divider/icon button

* Added changeset: `Stack` component to `ui` package

* refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174)

* Move Notice to UI package and update imports

* Add test imports

* Add renderWithTheme and other changes to make tests pass

* Fix broken icon imports

* Added changeset: Move `Notice` and `Tooltip` components to UI package

* Feedback @dwiley-akamai: consolidate imports and rename icon exports

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172)

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object.

* Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object.

* Update changeset description

Co-authored-by: Purvesh Makode <[email protected]>

* remove optional chaining

* change Text from "Subnets" to "Subnet"

* remove extra borderTop

* refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object

* Add descriptive variable name

---------

Co-authored-by: Purvesh Makode <[email protected]>

* upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226)

* upcoming: [DI-21814] - DBaaS instances order by label

* upcoming: [DI-21814] - Added changeset

* DI-21814: use map for better readability and optimisations

---------

Co-authored-by: vmangalr <[email protected]>

* UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231)

* feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* feat: [UIE-8193] - Tooltip context for small screens

* feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table

* feat: [UIE-8193] - Tooltip context for small screens

* DBaaS additions

* GPU egress transfer copy update (linode#11235)

* default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234)

Co-authored-by: Talmai Oliveira <[email protected]>

* Update PULL_REQUEST_TEMPLATE.md (linode#11219)

* change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221)

* Update 08-testing.md for userEvent

* Fix typo

* Address feedback; also further clean up linting issues the doc

* Fix a bad test that was not following good practices

* Added changeset: Update developer docs on unit testing user events

* Update changelog

* Fix LKE create ACL tests (linode#11237)

* feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179)

* feat: [M3-8665] - add option to copy token in LKE details page.

* Added changeset: option to copy token in LKE details page

* Change the "Copy Token" button to use asynchronous functionality

* remove extra styling

* refactor: [M3-8665] - add option to copy token in LKE details page.

* Change cypress test for LKE update spec

* fix: sx styling for Textfield component (linode#11246)

* spread containerProps sx

* spread props.sx as well whoops

* fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247)

* don't fetch when `type` is an empty string

* fix and changelog entry

---------

Co-authored-by: Banks Nussman <[email protected]>

* change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236)

* Make updates discussed to PR template during retro

* Add changeset

* refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (linode#11254)

* Move RadioGroup to ui package

* Added changeset: Move `RadioGroup` from `manager` to `ui` package

---------

Co-authored-by: corya-akamai <[email protected]>
Co-authored-by: Alban Bailly <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
Co-authored-by: Harsh Shankar Rao <[email protected]>
Co-authored-by: Jaalah Ramos <[email protected]>
Co-authored-by: rodonnel-akamai <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: venkatmano-akamai <[email protected]>
Co-authored-by: vmangalr <[email protected]>
Co-authored-by: Connie Liu <[email protected]>
Co-authored-by: Hussain Khalil <[email protected]>
Co-authored-by: hasyed-akamai <[email protected]>
Co-authored-by: Purvesh Makode <[email protected]>
Co-authored-by: ankitaakamai <[email protected]>
Co-authored-by: mpolotsk-akamai <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: John Callahan <[email protected]>
Co-authored-by: Mariah Jacobs <[email protected]>
Co-authored-by: jdamore-linode <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
jaalah-akamai pushed a commit that referenced this pull request Nov 18, 2024
…ts for the Create Alert Definition Form (#11255)

* Upcoming : [DI:21546] - Added the create button and name,description,severity components from General Information for the Create Alert Definition form

* Upcoming: [DI:21456] - Added unit test for AlertSeverity component, changed the naming of properties in the Alert type, updated the url of endpoint

* Upcoming: [DI:21546] - Added the unit test for CreateAlertDefinition component

* upcoming: [DI:21546] - Added the onChange for the tabs

* Upcoming: [DI-21546] - Removed unneccessary components and made changes to the Create Alert forma and Severity Select component

* Upcoming: [DI-21694] - Modified the changes with Severity component, modified and added appropriate types

* Upcoming: [DI-21694] - Added null as empty value for the Severity component, Fixed the Unit Tests for Severity component, fixed styling between components in Create Alert Form

* Merging latest develop changes  (#23)

* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (#11199)

* feat: [M3-8831] - New GPUv2 egress transfer display (#11209)

* Add new gpuV2 egress transferlogic

* light cleanup

* adjust e2e s

* Added changeset: New GPUv2 egress transfer helpers

* feedback @coliu-akamai @hkhalil-akamai

* feedback @coliu-akamai @jaalah-akamai

* feedback optimization

* change: [M3-8806] - Disable unsupported images for distributed regions (#11206)

## Description πŸ“
In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled

Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did

## Changes  πŸ”„
List any change relevant to the reviewer.
- Disable unsupported images/distros for distributed regions in Linode Create
- Removed the distributed icon & associated icon text
- Removed the word `currently` in the Add-Ons warning notice for distributed regions
- Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component

## Target release date πŸ—“οΈ
11/12

## How to test πŸ§ͺ

### Prerequisites
(How to setup test environment)
- Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags

### Verification steps
(How to verify changes)
- Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab:
  - Select a core region -> No Images/distributions should be disabled
  - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled
- There should be no regressions in the components that were refactored
- Ensure unit tests and e2e tests are passing locally/remotely

* fix: [UIE-8246] - DBaaS provisioning 2 node clusters (#11218)

* feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (#11178)

* feat: [M3-8528] - Include Object Storage in Support Tickets

* query change

* Added changeset: Include Object Storage buckets in Support tickets dropdown

* added link support for object storage

* removed redundant query

* query updation and restructuring request payload

* Added changeset

* Initial Changelog

* refactor: [M3-8646] – Migrate `Divider` to `ui` package  (#11205)

* refactor: [M3-8646] – Migrate `Divider` to `ui` package

* Added changeset: Migrate Divider to ui package

* migrating all  imports

* removing redundant hook imports

* updated the import for omittedProps

* UIE-8247: Conditionally give the new docs as the link on database landing page (#11227)

* fix: [M3-8764] - Kubernetes UI issues (#11217)

* initial clean up

* save progress

* add changeset

* fix type error

* feedback @mjac0bs

* a few more small fixes

* a few more small fixes

---------

Co-authored-by: Banks Nussman <[email protected]>

* upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (#11225)

* upcoming: [DI-18419] - chart post processing for missing timestamps

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Added changeset

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - early returns for empty array

---------

Co-authored-by: vmangalr <[email protected]>

* Update changelog

* refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (#11228)

* migrate stack, update organization for divider/icon button

* Added changeset: `Stack` component to `ui` package

* refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (#11174)

* Move Notice to UI package and update imports

* Add test imports

* Add renderWithTheme and other changes to make tests pass

* Fix broken icon imports

* Added changeset: Move `Notice` and `Tooltip` components to UI package

* Feedback @dwiley-akamai: consolidate imports and rename icon exports

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (#11172)

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object.

* Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object.

* Update changeset description

Co-authored-by: Purvesh Makode <[email protected]>

* remove optional chaining

* change Text from "Subnets" to "Subnet"

* remove extra borderTop

* refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object

* Add descriptive variable name

---------

Co-authored-by: Purvesh Makode <[email protected]>

* upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (#11226)

* upcoming: [DI-21814] - DBaaS instances order by label

* upcoming: [DI-21814] - Added changeset

* DI-21814: use map for better readability and optimisations

---------

Co-authored-by: vmangalr <[email protected]>

* UIE-8254: Add tooltip for ipv6 for new db clusters (#11231)

* feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (#11232)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* feat: [UIE-8193] - Tooltip context for small screens

* feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table

* feat: [UIE-8193] - Tooltip context for small screens

* DBaaS additions

* GPU egress transfer copy update (#11235)

* default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (#11234)

Co-authored-by: Talmai Oliveira <[email protected]>

* Update PULL_REQUEST_TEMPLATE.md (#11219)

* change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (#11221)

* Update 08-testing.md for userEvent

* Fix typo

* Address feedback; also further clean up linting issues the doc

* Fix a bad test that was not following good practices

* Added changeset: Update developer docs on unit testing user events

* Update changelog

* Fix LKE create ACL tests (#11237)

* feat: [M3-8665] - add option to copy token in LKE details page. (#11179)

* feat: [M3-8665] - add option to copy token in LKE details page.

* Added changeset: option to copy token in LKE details page

* Change the "Copy Token" button to use asynchronous functionality

* remove extra styling

* refactor: [M3-8665] - add option to copy token in LKE details page.

* Change cypress test for LKE update spec

* fix: sx styling for Textfield component (#11246)

* spread containerProps sx

* spread props.sx as well whoops

* fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (#11247)

* don't fetch when `type` is an empty string

* fix and changelog entry

---------

Co-authored-by: Banks Nussman <[email protected]>

* change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (#11236)

* Make updates discussed to PR template during retro

* Add changeset

---------

Co-authored-by: corya-akamai <[email protected]>
Co-authored-by: Alban Bailly <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
Co-authored-by: Harsh Shankar Rao <[email protected]>
Co-authored-by: Jaalah Ramos <[email protected]>
Co-authored-by: rodonnel-akamai <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: venkatmano-akamai <[email protected]>
Co-authored-by: vmangalr <[email protected]>
Co-authored-by: Connie Liu <[email protected]>
Co-authored-by: Hussain Khalil <[email protected]>
Co-authored-by: hasyed-akamai <[email protected]>
Co-authored-by: Purvesh Makode <[email protected]>
Co-authored-by: ankitaakamai <[email protected]>
Co-authored-by: mpolotsk-akamai <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: John Callahan <[email protected]>
Co-authored-by: Mariah Jacobs <[email protected]>
Co-authored-by: jdamore-linode <[email protected]>
Co-authored-by: Hana Xu <[email protected]>

* Revert "Merging latest develop changes  (#23)" (#24)

This reverts commit 2887f18.

* Merging latest changes develop (#25)

* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (#11199)

* feat: [M3-8831] - New GPUv2 egress transfer display (#11209)

* Add new gpuV2 egress transferlogic

* light cleanup

* adjust e2e s

* Added changeset: New GPUv2 egress transfer helpers

* feedback @coliu-akamai @hkhalil-akamai

* feedback @coliu-akamai @jaalah-akamai

* feedback optimization

* change: [M3-8806] - Disable unsupported images for distributed regions (#11206)

## Description πŸ“
In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled

Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did

## Changes  πŸ”„
List any change relevant to the reviewer.
- Disable unsupported images/distros for distributed regions in Linode Create
- Removed the distributed icon & associated icon text
- Removed the word `currently` in the Add-Ons warning notice for distributed regions
- Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component

## Target release date πŸ—“οΈ
11/12

## How to test πŸ§ͺ

### Prerequisites
(How to setup test environment)
- Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags

### Verification steps
(How to verify changes)
- Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab:
  - Select a core region -> No Images/distributions should be disabled
  - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled
- There should be no regressions in the components that were refactored
- Ensure unit tests and e2e tests are passing locally/remotely

* fix: [UIE-8246] - DBaaS provisioning 2 node clusters (#11218)

* feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (#11178)

* feat: [M3-8528] - Include Object Storage in Support Tickets

* query change

* Added changeset: Include Object Storage buckets in Support tickets dropdown

* added link support for object storage

* removed redundant query

* query updation and restructuring request payload

* Added changeset

* Initial Changelog

* refactor: [M3-8646] – Migrate `Divider` to `ui` package  (#11205)

* refactor: [M3-8646] – Migrate `Divider` to `ui` package

* Added changeset: Migrate Divider to ui package

* migrating all  imports

* removing redundant hook imports

* updated the import for omittedProps

* UIE-8247: Conditionally give the new docs as the link on database landing page (#11227)

* fix: [M3-8764] - Kubernetes UI issues (#11217)

* initial clean up

* save progress

* add changeset

* fix type error

* feedback @mjac0bs

* a few more small fixes

* a few more small fixes

---------

Co-authored-by: Banks Nussman <[email protected]>

* upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (#11225)

* upcoming: [DI-18419] - chart post processing for missing timestamps

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Code corrections and refactoring

* upcoming: [DI-21811] - Added changeset

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - comment updates

* upcoming: [DI-21811] - early returns for empty array

---------

Co-authored-by: vmangalr <[email protected]>

* Update changelog

* refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (#11228)

* migrate stack, update organization for divider/icon button

* Added changeset: `Stack` component to `ui` package

* refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (#11174)

* Move Notice to UI package and update imports

* Add test imports

* Add renderWithTheme and other changes to make tests pass

* Fix broken icon imports

* Added changeset: Move `Notice` and `Tooltip` components to UI package

* Feedback @dwiley-akamai: consolidate imports and rename icon exports

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (#11172)

* change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object.

* Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object.

* Update changeset description

Co-authored-by: Purvesh Makode <[email protected]>

* remove optional chaining

* change Text from "Subnets" to "Subnet"

* remove extra borderTop

* refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object

* Add descriptive variable name

---------

Co-authored-by: Purvesh Makode <[email protected]>

* upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (#11226)

* upcoming: [DI-21814] - DBaaS instances order by label

* upcoming: [DI-21814] - Added changeset

* DI-21814: use map for better readability and optimisations

---------

Co-authored-by: vmangalr <[email protected]>

* UIE-8254: Add tooltip for ipv6 for new db clusters (#11231)

* feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (#11232)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* feat: [UIE-8193] - Tooltip context for small screens

* feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223)

* feat: [UIE-8193] - Tooltip for Create/Resize Database table

* Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table

* feat: [UIE-8193] - Tooltip context for small screens

* DBaaS additions

* GPU egress transfer copy update (#11235)

* default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (#11234)

Co-authored-by: Talmai Oliveira <[email protected]>

* Update PULL_REQUEST_TEMPLATE.md (#11219)

* change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (#11221)

* Update 08-testing.md for userEvent

* Fix typo

* Address feedback; also further clean up linting issues the doc

* Fix a bad test that was not following good practices

* Added changeset: Update developer docs on unit testing user events

* Update changelog

* Fix LKE create ACL tests (#11237)

* feat: [M3-8665] - add option to copy token in LKE details page. (#11179)

* feat: [M3-8665] - add option to copy token in LKE details page.

* Added changeset: option to copy token in LKE details page

* Change the "Copy Token" button to use asynchronous functionality

* remove extra styling

* refactor: [M3-8665] - add option to copy token in LKE details page.

* Change cypress test for LKE update spec

* fix: sx styling for Textfield component (#11246)

* spread containerProps sx

* spread props.sx as well whoops

* fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (#11247)

* don't fetch when `type` is an empty string

* fix and changelog entry

---------

Co-authored-by: Banks Nussman <[email protected]>

* change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (#11236)

* Make updates discussed to PR template during retro

* Add changeset

* refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (#11254)

* Move RadioGroup to ui package

* Added changeset: Move `RadioGroup` from `manager` to `ui` package

---------

Co-authored-by: corya-akamai <[email protected]>
Co-authored-by: Alban Bailly <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
Co-authored-by: Harsh Shankar Rao <[email protected]>
Co-authored-by: Jaalah Ramos <[email protected]>
Co-authored-by: rodonnel-akamai <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: venkatmano-akamai <[email protected]>
Co-authored-by: vmangalr <[email protected]>
Co-authored-by: Connie Liu <[email protected]>
Co-authored-by: Hussain Khalil <[email protected]>
Co-authored-by: hasyed-akamai <[email protected]>
Co-authored-by: Purvesh Makode <[email protected]>
Co-authored-by: ankitaakamai <[email protected]>
Co-authored-by: mpolotsk-akamai <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: John Callahan <[email protected]>
Co-authored-by: Mariah Jacobs <[email protected]>
Co-authored-by: jdamore-linode <[email protected]>
Co-authored-by: Hana Xu <[email protected]>

* upcoming:  [DI-21694] - Added changesets

* upcoming : [DI-21694] - Addressed the review comments

* upcoming: [DI-21694] - Fixed the type safety issue for the AlertSeveritySelect component

* upcoming: [DI-21694] - Fixed the dependency if Button component that was failing the test

---------

Co-authored-by: corya-akamai <[email protected]>
Co-authored-by: Alban Bailly <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
Co-authored-by: Harsh Shankar Rao <[email protected]>
Co-authored-by: Jaalah Ramos <[email protected]>
Co-authored-by: rodonnel-akamai <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: Banks Nussman <[email protected]>
Co-authored-by: venkatmano-akamai <[email protected]>
Co-authored-by: vmangalr <[email protected]>
Co-authored-by: Connie Liu <[email protected]>
Co-authored-by: Hussain Khalil <[email protected]>
Co-authored-by: hasyed-akamai <[email protected]>
Co-authored-by: Purvesh Makode <[email protected]>
Co-authored-by: ankitaakamai <[email protected]>
Co-authored-by: mpolotsk-akamai <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: Talmai Oliveira <[email protected]>
Co-authored-by: John Callahan <[email protected]>
Co-authored-by: Mariah Jacobs <[email protected]>
Co-authored-by: jdamore-linode <[email protected]>
Co-authored-by: Hana Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants