feat: [UIE-8138, UIE-8139] - IAM RBAC: add new assigned roles table component part 2 #11762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaleksee-akamai
requested review from
coliu-akamai and
bill-akamai
and removed request for
a team
aaleksee-akamai
force-pushed
the
UIE-8138-iam-rbac-assigned-roles-table-part-2
branch
from
dff0da4 to
9b682f4
Compare
|
Coverage Report: ✅ |
* improve-banner-spacing * update test * add changeset --------- Co-authored-by: Banks Nussman <[email protected]>
aaleksee-akamai
force-pushed
the
UIE-8138-iam-rbac-assigned-roles-table-part-2
branch
from
9b682f4 to
569c5ee
Compare
aaleksee-akamai
commented
Feb 28, 2025
| * Group account_access and resource_access roles of the user | ||
| * | ||
| */ | ||
| const combineRoles = (data: IamUserPermissions): CombinedRoles[] => { |
There was a problem hiding this comment.
moved all func to utilities.ts
aaleksee-akamai
commented
Feb 28, 2025
| const getResourceTypes = (data: RoleMap[]): EntitiesType[] => | ||
| mapEntityTypes(data, ' Roles'); | ||
|
|
||
| export const StyledTypography = styled(Typography, { |
aaleksee-akamai
commented
Feb 28, 2025
| @@ -7,13 +7,6 @@ export const sxTooltipIcon = { | |||
| padding: 0, | |||
| }; | |||
|
|
|||
| export const StyledTypography = styled(Typography, { | |||
aaleksee-akamai
commented
Feb 28, 2025
| @@ -46,23 +42,6 @@ export const StyledClampedContent = styled('div', { | |||
| export const StyledBox = styled(Box, { | |||
| label: 'StyledBox', | |||
| })(({ theme }) => ({ | |||
| backgroundColor: | |||
aaleksee-akamai
commented
Feb 28, 2025
| })); | ||
|
|
||
| export const StyledSpan = styled(Typography, { label: 'StyledSpan' })( |
aaleksee-akamai
commented
Feb 28, 2025
|
|
||
| const itemRefs = React.useRef<(HTMLSpanElement | null)[]>([]); | ||
|
|
||
| const calculateHiddenItems = React.useCallback(() => { |
There was a problem hiding this comment.
move that func to utilities.ts, it's used by 2 components (Permissions and Assigned Entities) now
aaleksee-akamai
commented
Feb 28, 2025
| @@ -2,7 +2,7 @@ import { Autocomplete, Typography } from '@linode/ui'; | |||
| import { capitalize } from '@linode/utilities'; | |||
| import { Grid } from '@mui/material'; | |||
| import React from 'react'; | |||
| import { useParams } from 'react-router-dom'; | |||
| import { useLocation, useParams } from 'react-router-dom'; | |||
|
|
|||
There was a problem hiding this comment.
move from Shared folder cause it's not shared, i'll do the same for AssignedRolesTable in the next PR
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
|||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAM RBAC - update assigned roles and entities table components.
Description 📝
Highlight the Pull Request's context and intentions.
Changes 🔄
List any change(s) relevant to the reviewer.
View entitiesutilitiesand add test for itTarget release date 🗓️
dev
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
Assigned Rolesor click on the user's menuView User RolesVerification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅