Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zooming #78

Closed
PizzaLovingNerd opened this issue Aug 2, 2019 · 6 comments
Closed

Zooming #78

PizzaLovingNerd opened this issue Aug 2, 2019 · 6 comments
Labels
duplicate This issue or pull request already exists feature request new features that don't exist at all
Milestone
0.6.0

Comments

@PizzaLovingNerd
Copy link

Great work on drawing, but here are some features I would want.

I think you should be able to zoom in and out. It's annoying when I want to make a 1080p image, but you have to scroll to access the other sides. The ability to zoom in and out would be a welcome change.
@PizzaLovingNerd PizzaLovingNerd added the enhancement ideas to improve existing features label Aug 2, 2019
@maoschanz maoschanz added the duplicate This issue or pull request already exists label Aug 2, 2019
@maoschanz
Copy link
Owner

there are already issues about that even if they don't have a pertinent name, it'll be in the version 0.6

@PizzaLovingNerd
Copy link
Author

Ok, sorry

@maoschanz
Copy link
Owner

it can stay open, so people will see it better

@maoschanz maoschanz reopened this Aug 6, 2019
maoschanz added a commit that referenced this issue Aug 18, 2019
@maoschanz
Refactor how bottom panels work
82ff7f0 
This commit actually does a ton of things:

- object-oriented bottom panels (#21) despite dramatic regressions regarding adaptativity to screen width
- update accurately all preview buttons when zooming (#78)
- merge "flip" and "rotate" into a single tool
- add a gtkscalebutton (#64) but adaptativity is broken anyway so...
- improve blur (#21)
maoschanz added a commit that referenced this issue Sep 8, 2019
@maoschanz
Fix numerous zoom-related problems
8ed39d0 
that's cards in project n°4, and issue #78 (also it's mentionned in #54 and others)

- scrollbars change their capacity/size to match the zoom level so we can scroll with zoomed images
- the minimap is now produced with quite different methods to take into account the zoom level
- the minimap button now shows a translatable label which is updated when the user changes the active tab
- the coordinates used by the tools to draw are now correct according to the zoom level
@maoschanz maoschanz added this to the 0.6 milestone Oct 20, 2019
maoschanz added a commit that referenced this issue Oct 25, 2019
@maoschanz
Cease the clowneries with the crop tool
86e4cb3 
Related to issues #80 #85 #21, this commit changes how all canvas tools preview and apply their modifications. Like the abstract selection tool, they now use locals delta_x and delta_y to preview changes of selection_x and selection_y without actually changing the values. The method deciding what direction the mouse cursor uses has been moved to abstract_canvas_tool so it will be used to scale in all directions using local deltas.
Both scale and crop tools now provide access to basic zoom controls, which balance the deletion of the idiot auto-unzoomed preview. The crop tool panel should now be resizable regardless of internationalised strings.

Cropping or scaling the selection while (un)zooming (#78) is still problematic in several cases
@Bundy01
Copy link

Bundy01 commented Dec 18, 2019

Hello,

indeed a zoom was welcome. I will add to this list an eraser and the possibility with the "swivel" tool to choose the rotation angle (not only by 90° angle).

Thank you.

@maoschanz
Copy link
Owner

maoschanz commented Dec 18, 2019 •
edited
Loading

Not sure how you expect the eraser to work (you should open a distinct issue to explain), but the 2 other features are already working in the (still unstable) future version 0.6 of the app

@Bundy01
Copy link

Bundy01 commented Dec 18, 2019 •
edited
Loading

Okay,
I'm looking forward to version 0.6. For the eraser, I didn't understand, do you want me to create a new issue?

I hadn't seen the edit:). I'll make the issue.

@maoschanz maoschanz mentioned this issue Jul 13, 2020
Closed
25 tasks
@maoschanz maoschanz added feature request new features that don't exist at all and removed enhancement ideas to improve existing features labels Jul 26, 2020
maoschanz added a commit that referenced this issue Aug 18, 2020
@maoschanz
Use the pre-transformed coords to compute scaling and cropping
943488f 
these canvas tools' mouse signals were ignoring the zoom level (#214)

issue #78 is almost finished
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists feature request new features that don't exist at all
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@PizzaLovingNerd @maoschanz @Bundy01