Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

again an issue with the horrible "temp_pixbuf" thing #80

Closed
maoschanz opened this issue Aug 2, 2019 · 1 comment
Closed

again an issue with the horrible "temp_pixbuf" thing #80

maoschanz opened this issue Aug 2, 2019 · 1 comment
Labels
bug Something isn't working tools bugs or suggestions related to tools

Comments

@maoschanz
Copy link
Owner

Description

whatever happened around 2:50 https://www.youtube.com/watch?v=uYBNI6ExeWY

Steps to reproduce the bug:

  1. ...
  2. ...
  3. ...

Expected behavior

not this

System

  • Device (desktop computer/tablet/phone/...):
  • OS:
  • Desktop environment:
  • Package format (flatpak, DEB, AUR ?): Flatpak
  • App version: 0.4.2
@maoschanz maoschanz added bug Something isn't working tools bugs or suggestions related to tools labels Aug 2, 2019
@maoschanz
Copy link
Owner Author

can't reproduce with the current version so i may have accidentally fixed it

maoschanz added a commit that referenced this issue Oct 25, 2019
@maoschanz
Cease the clowneries with the crop tool
86e4cb3 
Related to issues #80 #85 #21, this commit changes how all canvas tools preview and apply their modifications. Like the abstract selection tool, they now use locals delta_x and delta_y to preview changes of selection_x and selection_y without actually changing the values. The method deciding what direction the mouse cursor uses has been moved to abstract_canvas_tool so it will be used to scale in all directions using local deltas.
Both scale and crop tools now provide access to basic zoom controls, which balance the deletion of the idiot auto-unzoomed preview. The crop tool panel should now be resizable regardless of internationalised strings.

Cropping or scaling the selection while (un)zooming (#78) is still problematic in several cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tools bugs or suggestions related to tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maoschanz