[ios, macos] Enable localizations in iosapp & macosapp #8105
Conversation
friedbunny
added
iOS
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @1ec5 and @tmcw to be potential reviewers. |
friedbunny
force-pushed
the
fb-iosapp-localizable
branch
from
bf81441 to
55b0960
Compare
| @@ -0,0 +1,8 @@ | |||
|
|
|||
| /* | |||
| File.strings | |||
There was a problem hiding this comment.
Move this file to Base.lproj. A base localization will be reused by all localizations without the need to a separate stub file for each localization.
| @@ -119,6 +119,7 @@ Once you’ve finished translating the SDK into a new language in Transifex, per | |||
| 1. In ios.xcworkspace, open the project editor for ios.xcodeproj. Using the project editor’s sidebar or tab bar dropdown, go to the “ios” project; under the Localizations section of the Info tab, click the + button to add your language to the project. | |||
| 1. In the sheet that appears, select all the .strings and .stringsdict files but not the .storyboard file. (LaunchScreen.storyboard is part of the iosapp example application, which is not localized.) If your language lacks declension and pluralization, as in the case of Chinese, omit the .stringsdict files. | |||
| 1. In the Project navigator, expand each .stringsdict file in the project. An additional version for your localization should be listed; translate it. See Apple’s documentation on the [.stringsdict format](https://developer.apple.com/library/content/documentation/MacOSX/Conceptual/BPInternational/StringsdictFileFormat/StringsdictFileFormat.html). | |||
| 1. In the Project navigator, select Demo App/Localizable.strings and then, in the File Inspector, check the box for your new localization. | |||
There was a problem hiding this comment.
As long as you use a base localization, the Localizable.strings for iosapp will be localized as part of the step before last.
|
Base localization via storyboards (or just by not checking any of the other Localizable.strings boxes) does seem like a better way to do this, but I couldn’t make language-switching update the app’s strings reliably in the simulator:
|
|
More languages are being added in #8113. |
friedbunny
force-pushed
the
fb-iosapp-localizable
branch
from
cd0c814 to
b937b4a
Compare
|
Rebased on master and fixed a conflict in the macOS project. Not sure if rebasing will fix the consistently failing Node macOS test, though... |
friedbunny
force-pushed
the
fb-iosapp-localizable
branch
from
b937b4a to
5a63f98
Compare
|
After another rebase, tests are finally passing. Needs a 👍 before it can be merged. |
friedbunny
force-pushed
the
fb-iosapp-localizable
branch
from
5a63f98 to
e30de34
Compare
|
Added the new localizations from #8113, rebased and squashed. |
friedbunny
force-pushed
the
fb-iosapp-localizable
branch
from
e30de34 to
4f91e70
Compare
Adds blank
Localizable.stringsto iosapp and macapp, so that our SDK localizations will be used in those apps.