-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Lithuanian, Polish, Russian, Spanish, Ukrainian #8113
Conversation
@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @friedbunny and @incanus to be potential reviewers. |
@1ec5 not sure if you are interested in such details, but Russian nouns can have up 3 plural forms and it requires some logic to choose the right one. Not a big deal, but can be a bit cringeworthy when it's wrong. |
Thanks @vkurchatkin, we definitely want to get these details right. Can you point out what the three plural forms should be for the messages in platform/darwin/resources/ru.lproj/Foundation.stringsdict and under what circumstances we’d use each form? (These messages are used in MGLCoordinateFormatter, for example so that VoiceOver will read a coordinate as “55 degrees, 45 minutes, and 8 seconds”.) |
According to this: http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#ru you have to specify |
Can you fill out the following table?
Thanks! |
Sure:
One caveat: this is only nominative case, so these forms are not applicable in some contexts. |
Awesome – fixed in e4eca52. |
It seems that Polish and Ukrainian are similar to Russian in this regard |
<key>one</key> | ||
<string>%d minuta</string> | ||
<key>other</key> | ||
<string>%d minuty</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codecalm, can you fill out this table?
English | one |
few |
many |
---|---|---|---|
degree | |||
minute | |||
second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
English | one |
few |
many |
---|---|---|---|
degree | stopień | stopnie | stopni |
minute | minuta | minuty | minut |
second | sekunda | sekundy | sekund |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks – incorporated in f76cfe5.
The relevant messages haven’t been translated into Ukrainian on Transifex, but perhaps @Andygol or @mourner could help with the plural forms for “degree”, “minute”, and “second” too.
Unfortunately, this is generally the case with NSFormatter subclasses on Apple platforms. If an application needs a different case, it normally needs to come up with its own localizable strings to be translated in context. |
a3a0c05
to
e312cf7
Compare
Pulled the latest translations from Transifex and added new languages to the iOS and macOS projects. Added .stringsdict files according to issues posted to Transifex by translators. The tx configuration included languages with at least one file translated 80% or more. Lithuanian, Polish, Russian, Spanish, and Ukrainian are all partial translations at this time.
/cc @Andygol