Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Lithuanian, Polish, Russian, Spanish, Ukrainian #8113

Merged
merged 6 commits into from
Feb 20, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Feb 19, 2017

Pulled the latest translations from Transifex and added new languages to the iOS and macOS projects. Added .stringsdict files according to issues posted to Transifex by translators. The tx configuration included languages with at least one file translated 80% or more. Lithuanian, Polish, Russian, Spanish, and Ukrainian are all partial translations at this time.

/cc @Andygol

@1ec5 1ec5 added this to the ios-v3.5.0 milestone Feb 19, 2017
@1ec5 1ec5 self-assigned this Feb 19, 2017
@1ec5 1ec5 requested a review from friedbunny February 19, 2017 00:05
@mention-bot
Copy link

@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @friedbunny and @incanus to be potential reviewers.

@vkurchatkin
Copy link
Contributor

vkurchatkin commented Feb 19, 2017

@1ec5 not sure if you are interested in such details, but Russian nouns can have up 3 plural forms and it requires some logic to choose the right one. Not a big deal, but can be a bit cringeworthy when it's wrong.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 19, 2017

Thanks @vkurchatkin, we definitely want to get these details right. Can you point out what the three plural forms should be for the messages in platform/darwin/resources/ru.lproj/Foundation.stringsdict and under what circumstances we’d use each form? (These messages are used in MGLCoordinateFormatter, for example so that VoiceOver will read a coordinate as “55 degrees, 45 minutes, and 8 seconds”.)

@vkurchatkin
Copy link
Contributor

According to this: http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#ru you have to specify one, many and few.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 19, 2017

Can you fill out the following table?

English one few many
degree
minute
second

Thanks!

@vkurchatkin
Copy link
Contributor

Sure:

English one few many
degree градус градуса градусов
minute минута минуты минут
second секунда секунды секунд

One caveat: this is only nominative case, so these forms are not applicable in some contexts.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 19, 2017

Awesome – fixed in e4eca52.

@vkurchatkin
Copy link
Contributor

It seems that Polish and Ukrainian are similar to Russian in this regard

<key>one</key>
<string>%d minuta</string>
<key>other</key>
<string>%d minuty</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecalm, can you fill out this table?

English one few many
degree
minute
second

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

English one few many
degree stopień stopnie stopni
minute minuta minuty minut
second sekunda sekundy sekund

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks – incorporated in f76cfe5.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 19, 2017

The relevant messages haven’t been translated into Ukrainian on Transifex, but perhaps @Andygol or @mourner could help with the plural forms for “degree”, “minute”, and “second” too.

this is only nominative case, so these forms are not applicable in some contexts.

Unfortunately, this is generally the case with NSFormatter subclasses on Apple platforms. If an application needs a different case, it normally needs to come up with its own localizable strings to be translated in context.

@Andygol
Copy link
Contributor

Andygol commented Feb 20, 2017

The relevant messages haven’t been translated into Ukrainian

Here is Ukranian translation 🇺🇦

English one few many
degree градус градуси градусів
minute хвилина хвилини хвилин
second секунда секунди секунд

/cc @1ec5 @mourner a3a0c05

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS labels Feb 20, 2017
@1ec5 1ec5 force-pushed the 1ec5-transifex-v3.5.0-beta.2 branch from a3a0c05 to e312cf7 Compare February 20, 2017 20:17
@1ec5 1ec5 changed the title Polish, Russian, Spanish, Ukrainian Lithuanian, Polish, Russian, Spanish, Ukrainian Feb 20, 2017
@1ec5 1ec5 merged commit b845af6 into master Feb 20, 2017
@1ec5 1ec5 deleted the 1ec5-transifex-v3.5.0-beta.2 branch February 20, 2017 22:55
@1ec5 1ec5 mentioned this pull request Mar 1, 2017
boundsj pushed a commit that referenced this pull request Mar 1, 2017
boundsj pushed a commit that referenced this pull request Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants