This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated by current/historical Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
…ents Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Still want to add more, concerning behaviour in the different states of the background updater completion. Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
unergonomic if we move to `async` from the bottom-up. Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
rooms – varies depending upon room publicness. Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
needed. Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
3 tasks
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #5847 +/- ##
===========================================
+ Coverage 63.41% 63.58% +0.16%
===========================================
Files 333 332 -1
Lines 36651 36494 -157
Branches 6057 6025 -32
===========================================
- Hits 23244 23203 -41
+ Misses 11755 11645 -110
+ Partials 1652 1646 -6 |
richvdh
reviewed
Aug 15, 2019
@@ -0,0 +1,2 @@ | |||
Rework room and user statistics to separate current & historical rows, as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one line for this please, btw
This was referenced Aug 19, 2019
Obsoleted by 8 other PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR blocks:
Not included in this PR:
FIXME: we could/should get this from room_stats when matthew/stats lands (handlers/sync.py)
To consider:
I still need to add a changelog and some documentation.