Separated Statistics [3/7ish] #5890
Conversation
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
reivilibre
changed the title
| room_stats_complete = True | ||
|
|
||
| elif typ == EventTypes.JoinRules: | ||
| old_room_state = yield self.store.get_room_state(room_id) |
There was a problem hiding this comment.
This is probably going to be more up to date room state?
There was a problem hiding this comment.
As discussed IRL (I think – lmk if mistaken), this should be fine, as the line underneath is responsible for updating the room_stats_state table upon which this (commented) line depends.
| @@ -103,6 +193,26 @@ def update_room_state(self, room_id, fields): | |||
| desc="update_room_state", | |||
| ) | |||
|
|
|||
| @cached() | |||
| def get_earliest_token_for_stats(self, stats_type, id): | |||
There was a problem hiding this comment.
Does this cache not need to be invalidated?
There was a problem hiding this comment.
I believe I have addressed this — but please can you check this specifically before resolving this comment? I feel like it's something that could easily bite in the bum if it's not correct.
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
`absolute_fields` being None shouldn't preclude completion of a current stats row. Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
| @defer.inlineCallbacks | ||
| def _unsafe_process(self): | ||
| # If self.pos is None then means we haven't fetched it from DB | ||
| if self.pos is None or None in self.pos.values(): |
There was a problem hiding this comment.
What does None in self.pos.values() mean?
There was a problem hiding this comment.
Adding a comment.
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
Signed-off-by: Olivier Wilkinson (reivilibre) [email protected]
This PR is the third in a series of PRs replacing #5847, which does the following:
These PRs will be merged into an intermediate branch (#5879) as some features may be broken if not all the PRs are applied at once.