Adds updateViaCache #6850

Blakelist7 · 2021-07-13T08:59:47Z

Adds updateViaCache() method to ServiceWorkerRegistration.

Adds `updateViaCache()` method to ServiceWorkerRegistration.

github-actions · 2021-07-13T09:02:34Z

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/ServiceWorkerContainer/register
Title: ServiceWorkerContainer.register()
on GitHub
Flaw count: 1

broken_links:
- Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules

URL: /en-US/docs/Web/API/ServiceWorkerRegistration
Title: ServiceWorkerRegistration
on GitHub
Flaw count: 2

bad_bcd_links:
- no explanation!
- no explanation!

External URLs

URL: /en-US/docs/Web/API/ServiceWorkerContainer/register
Title: ServiceWorkerContainer.register()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ServiceWorkerRegistration
Title: ServiceWorkerRegistration
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ServiceWorkerRegistration/updateViaCache
Title: ServiceWorkerRegistration.updateViaCache
on GitHub

https://jakearchibald.github.io/isserviceworkerready/ (1 time) (Note! This may be a new URL 👀)

(this comment was updated 2021-07-21 18:15:03.931201)

Blakelist7 · 2021-07-13T09:04:35Z

@hamishwillee can you help me in rephrasing the content of updateViaCache()?

jpmedley

Thank you for submitting this. This is free of typos, which I really appreciate. There are some matters of MDN style that you need to address. I'm available to answer questions and I'm here to help.

files/en-us/web/api/serviceworkerregistration/index.html

files/en-us/web/api/serviceworkerregistration/updateviacache/index.html

…ndex.html Co-authored-by: Joe Medley <[email protected]>

Co-authored-by: Joe Medley <[email protected]>

files/en-us/web/api/serviceworkerregistration/updateviacache/index.html

files/en-us/web/api/serviceworkerregistration/index.html

files/en-us/web/api/serviceworkerregistration/updateviacache/index.html

…ndex.html Co-authored-by: Joe Medley <[email protected]>

Blakelist7 · 2021-07-21T09:51:11Z

@jpmedley thank you for assisting me : )
I am done with the changes you requested.
I just have one suggestion to make, as you mentioned that updateviacache property is not implemented yet so shall we move it from Methods to Unimplemented properties in ServiceWorkerRegistration.

jpmedley

@Blakelist7 Thank you for your patience with this. The style of a reference work is different from the writing style you were taught in school. I think we're almost done, though.

files/en-us/web/api/serviceworkercontainer/register/index.html

files/en-us/web/api/serviceworkerregistration/updateviacache/index.html

files/en-us/web/api/serviceworkercontainer/register/index.html

Co-authored-by: Joe Medley <[email protected]>

…ndex.html Co-authored-by: Joe Medley <[email protected]>

robatwilliams · 2021-07-23T09:54:58Z

updateViaCache on the registration is a getter for the value it was originally registered with, as far as I can see - it's not a method.

https://w3c.github.io/ServiceWorker/#service-worker-registration-updateviacache

ServiceWorkerRegistration.update()
Checks the server for an updated version of the service worker without consulting caches.

Related to these changes. The "without consulting caches" part does seem to be the current behaviour in Chrome and Firefox (the only ones I tried). However I don't see anything in the spec (Update algorithm) that says it should behave this way. That bit was checked in in "initial en-us content checkin" on this repo, so I can't find any discussion/basis for it.

robatwilliams · 2021-07-23T10:17:36Z

Yes it appears the "without consulting caches" bit was removed at some point -

robatwilliams · 2021-07-23T12:22:09Z

I reported this about the "without consulting cache" thing, I might be wrong https://bugs.chromium.org/p/chromium/issues/detail?id=1232383.

jpmedley · 2021-07-29T14:34:16Z

@robatwilliams Can you please open a ticket on this issue and we'll handle it in a separate PR. Long-lived PRs have a tendency to acquire merge conflicts, and this one was getting a little old.

* 'main' of https://github.com/mdn/content: Adds updateViaCache (mdn#6850) Remove mentions of RTCDataChannelInit dictionary (mdn#7148) chore(deps): bump @mdn/yari from 0.4.652 to 0.4.658 (mdn#7427) Update PULL_REQUEST_TEMPLATE in GitHub actions (mdn#7405) Fix example in WebGL2RenderingContext.getBufferSubData (mdn#7418) Make CSS dl elements MArkdown-convertible (mdn#7403) Clarify WebGLContext.drawElements' count parameter (mdn#7417) Fix live sample for custom input validation (mdn#7408) Remove use of figure element from Web/CSS (mdn#7409) the label in the continue is optional. (mdn#7406) Change 'semantic' to 'semantics' (mdn#7401) Replace offensive words in CORS documentation (mdn#7396)

robatwilliams · 2021-07-29T16:34:20Z

Apologies, I was wrong about the issue and didn't mean to distract.

However the original point still stands, yet the PR was merged:

updateViaCache on the registration is a getter for the value it was originally registered with, as far as I can see - it's not a method.

robatwilliams · 2021-07-29T16:35:33Z

files/en-us/web/api/serviceworkercontainer/register/index.html

+          </li>
+        </ul>
+      </li>
+      <li><code>updateViaCache</code>: A string indicating how much of a service worker's resources will be updated when a call is made to {{domxref('ServiceWorkerRegistration.updateViaCache')}}. Valid values are:


Should say "when a calle is made to ServiceWorkerRegistration.update()"

robatwilliams · 2021-07-29T16:36:36Z

files/en-us/web/api/serviceworkerregistration/index.html

@@ -72,6 +72,8 @@ <h2 id="Methods">Methods</h2>
 <dd>Checks the server for an updated version of the service worker without consulting caches.</dd>
 <dt>{{domxref("ServiceWorkerRegistration.unregister()")}}</dt>
 <dd>Unregisters the service worker registration and returns a {{jsxref("Promise")}}. The service worker will finish any ongoing operations before it is unregistered.</dd>
+ <dt>{{domxref("ServiceWorkerRegistration.updateViaCache")}}</dt>


This is actually a property which allows you to retrieve the original value provided at registration.

robatwilliams · 2021-07-29T16:37:59Z

files/en-us/web/api/serviceworkerregistration/index.html

@@ -72,6 +72,8 @@ <h2 id="Methods">Methods</h2>
 <dd>Checks the server for an updated version of the service worker without consulting caches.</dd>


"without consulting caches" should be removed, or elaborated to mention respecing updateViaCache

robatwilliams · 2021-07-29T16:40:18Z

files/en-us/web/api/serviceworkerregistration/updateviacache/index.html

+---
+<div>{{APIRef("Service Workers API")}}</div>
+
+<p>The <code><strong>updateViaCache()</strong></code> method of the


As mentioned in the other comment, it's a property not a method.

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/update should be mention updateViaCache

robatwilliams · 2021-07-29T16:43:33Z

updateViaCache on the registration is a getter for the value it was originally registered with, as far as I can see - it's not a method.

I didn't originally consider it necessary to point out every individual incorrectness on this PR relating to this, but I now have.

Unless I'm misunderstood, IMO this PR should be reverted @jpmedley

Adds updateViaCache

79819a0

Adds `updateViaCache()` method to ServiceWorkerRegistration.

Blakelist7 requested a review from a team as a code owner July 13, 2021 08:59

Blakelist7 requested review from jpmedley and removed request for a team July 13, 2021 08:59

jpmedley requested changes Jul 19, 2021

View reviewed changes

Blakelist7 and others added 4 commits July 19, 2021 23:00

Update files/en-us/web/api/serviceworkerregistration/updateviacache/i…

728d566

…ndex.html Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkerregistration/updateviacache/i…

34501d6

…ndex.html Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkerregistration/index.html

6e7a78a

Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkerregistration/index.html

d3b2c20

Co-authored-by: Joe Medley <[email protected]>

jpmedley requested changes Jul 20, 2021

View reviewed changes

Blakelist7 and others added 3 commits July 20, 2021 22:26

Update files/en-us/web/api/serviceworkerregistration/updateviacache/i…

10f8323

…ndex.html Co-authored-by: Joe Medley <[email protected]>

remove note

b3f632a

Add type and updateViaCache options

110f010

Blakelist7 requested a review from jpmedley July 21, 2021 09:51

jpmedley requested changes Jul 21, 2021

View reviewed changes

Blakelist7 and others added 6 commits July 21, 2021 23:39

Update files/en-us/web/api/serviceworkercontainer/register/index.html

a60a826

Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkercontainer/register/index.html

7046af6

Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkercontainer/register/index.html

4d28325

Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkercontainer/register/index.html

1d14af9

Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkercontainer/register/index.html

fb08cfd

Co-authored-by: Joe Medley <[email protected]>

Update files/en-us/web/api/serviceworkerregistration/updateviacache/i…

1e0da10

…ndex.html Co-authored-by: Joe Medley <[email protected]>

Blakelist7 requested a review from jpmedley July 21, 2021 18:14

robatwilliams mentioned this pull request Jul 23, 2021

Issue with "ServiceWorkerContainer.register()": may be advisable to check for an existing registration #7138

Open

jpmedley approved these changes Jul 29, 2021

View reviewed changes

jpmedley merged commit cad672e into mdn:main Jul 29, 2021

robatwilliams reviewed Jul 29, 2021

View reviewed changes

github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds updateViaCache #6850

Adds updateViaCache #6850

Blakelist7 commented Jul 13, 2021 •

edited

Loading

github-actions bot commented Jul 13, 2021 •

edited

Loading

Blakelist7 commented Jul 13, 2021 •

edited

Loading

jpmedley left a comment

Blakelist7 commented Jul 21, 2021 •

edited

Loading

jpmedley left a comment

robatwilliams commented Jul 23, 2021

robatwilliams commented Jul 23, 2021

robatwilliams commented Jul 23, 2021

jpmedley commented Jul 29, 2021

robatwilliams commented Jul 29, 2021

robatwilliams Jul 29, 2021

robatwilliams Jul 29, 2021

robatwilliams Jul 29, 2021

robatwilliams Jul 29, 2021

robatwilliams commented Jul 29, 2021

		@@ -72,6 +72,8 @@ <h2 id="Methods">Methods</h2>
		<dd>Checks the server for an updated version of the service worker without consulting caches.</dd>

Adds updateViaCache #6850

Adds updateViaCache #6850

Conversation

Blakelist7 commented Jul 13, 2021 • edited Loading

github-actions bot commented Jul 13, 2021 • edited Loading

Preview URLs

Flaws

External URLs

Blakelist7 commented Jul 13, 2021 • edited Loading

jpmedley left a comment

Choose a reason for hiding this comment

Blakelist7 commented Jul 21, 2021 • edited Loading

jpmedley left a comment

Choose a reason for hiding this comment

robatwilliams commented Jul 23, 2021

robatwilliams commented Jul 23, 2021

robatwilliams commented Jul 23, 2021

jpmedley commented Jul 29, 2021

robatwilliams commented Jul 29, 2021

robatwilliams Jul 29, 2021

Choose a reason for hiding this comment

robatwilliams Jul 29, 2021

Choose a reason for hiding this comment

robatwilliams Jul 29, 2021

Choose a reason for hiding this comment

robatwilliams Jul 29, 2021

Choose a reason for hiding this comment

robatwilliams commented Jul 29, 2021

Blakelist7 commented Jul 13, 2021 •

edited

Loading

github-actions bot commented Jul 13, 2021 •

edited

Loading

Blakelist7 commented Jul 13, 2021 •

edited

Loading

Blakelist7 commented Jul 21, 2021 •

edited

Loading