Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Markdown] Remove figure element #7409

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[Markdown] Remove figure element #7409

merged 1 commit into from
Jul 29, 2021

Conversation

wbamberg
Copy link
Collaborator

There were 8 occurrences of the <figure> element in the CSS docs. While semantic markup is nice, we don't have a way to express this in GFM, so I'm removing it.

@wbamberg wbamberg requested a review from a team as a code owner July 29, 2021 03:02
@wbamberg wbamberg requested review from ericwbailey and removed request for a team July 29, 2021 03:03
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/hyphens
Title: hyphens
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Text/Wrapping_text

External URLs

URL: /en-US/docs/Web/CSS/forced-color-adjust
Title: forced-color-adjust
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/overflow-inline
Title: overflow-inline
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/overflow-block
Title: overflow-block
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/overflow-x
Title: overflow-x
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/hyphens
Title: hyphens
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/overflow-clip-margin
Title: overflow-clip-margin
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/overflow-y
Title: overflow-y
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/flex-basis
Title: flex-basis
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit fd2be81 into mdn:main Jul 29, 2021
Anurella added a commit to Anurella/content that referenced this pull request Jul 29, 2021
@Anurella
Merge branch 'main' of https://github.com/mdn/content into arrayFill
f9ebb8e 
* 'main' of https://github.com/mdn/content:
  Adds updateViaCache (mdn#6850)
  Remove mentions of RTCDataChannelInit dictionary (mdn#7148)
  chore(deps): bump @mdn/yari from 0.4.652 to 0.4.658 (mdn#7427)
  Update PULL_REQUEST_TEMPLATE in GitHub actions (mdn#7405)
  Fix example in WebGL2RenderingContext.getBufferSubData (mdn#7418)
  Make CSS dl elements MArkdown-convertible (mdn#7403)
  Clarify WebGLContext.drawElements' count parameter (mdn#7417)
  Fix live sample for custom input validation (mdn#7408)
  Remove use of figure element from Web/CSS (mdn#7409)
  the label in the continue is optional. (mdn#7406)
  Change 'semantic' to 'semantics' (mdn#7401)
  Replace offensive words in CORS documentation (mdn#7396)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
@wbamberg wbamberg deleted the remove-css-figures branch October 15, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @teoli2003