feat(sidebar): add filter #8968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
sidebar-filter
branch
2 times, most recently
from
432d41d to
0a0d004
Compare
This caused the TOC to display on top of the filter.
Chrome was suggesting previously typed queries.
In Chrome and Safari innerText seems to be empty for elements that are hidden in a collapsed details element.
Avoids that " " finds matches.
caugner
commented
Jun 8, 2023
caugner
commented
Jun 8, 2023
caugner
commented
Jun 8, 2023
caugner
commented
Jun 8, 2023
caugner
commented
Jun 8, 2023
Avoid executing the effect on every re-render.
The `.glean-thumbs` are now left-aligned with the filter icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-418)
Problem
We have some long sidebars with several collapsible sections, and so far users can discover sidebar content only by scrolling through the sidebar and manually expanding those sections.
Solution
Adds a filter field that allows users to quickly filter the sidebar.
When focusing the field, a feedback prompt with thumbs up/down
buttons appears below the input field, which we keep for 2-3 weeks.
Once feedback is given, the prompt does no longer appear for a user.
When filtering, the number of matches is shown inside the input field,
and only matching sidebar items (along with their parents and section
heading, if exists) are shown, with the text matches being highlighted.
This includes three measurements to evaluate the feature:
Screenshots
Before
After
How did you test this change?
QA by @mirunacurtean