Code

feat(sidebar): add filter#8968

Code

Merged

caugner merged 123 commits intomainmdn/yari:mainfrom sidebar-filtermdn/yari:sidebar-filterCopy head branch name to clipboardJun 8, 2023

+807-13

Commits

Commits on Jun 1, 2023

• feat(sidebar): add filter field (w/o logic)

  caugner

  committed
  46b1c80

  Copy full SHA for 46b1c80

• feat(sidebar): implement filtering

  caugner

  committed
  119c9e8

  Copy full SHA for 119c9e8

• chore(sidebar): split query like quicksearch

  caugner

  committed
  9b81921

  Copy full SHA for 9b81921

• feat(sidebar): implement SidebarFilterer with highlighting

  caugner

  committed
  98a7538

  Copy full SHA for 98a7538

• feat(sidebar): style filter, add icons + clear button

  caugner

  committed
  960657d

  Copy full SHA for 960657d

• fixup! feat(sidebar): style filter, add icons + clear button

  caugner

  committed
  17dabf8

  Copy full SHA for 17dabf8

• fix(sidebar): make filter sticky

  caugner

  committed
  8f2435e

  Copy full SHA for 8f2435e

• feat(sidebar): add thumbs to rate feature

  caugner

  committed
  26eb290

  Copy full SHA for 26eb290

• fix(sidebar): fix button/icon placement

  caugner

  committed
  db550ef

  Copy full SHA for db550ef

• fix(sidebar): stop fading out top area

  caugner

  committed
  3340c8c

  Copy full SHA for 3340c8c

• chore(sidebar): refine layout + thumbs

  caugner

  committed
  4c34a7d

  Copy full SHA for 4c34a7d

• fix(sidebar): highlight matches in recursive text nodes

  caugner

  committed
  7d34401

  Copy full SHA for 7d34401

• fixup! fix(sidebar): highlight matches in recursive text nodes

  caugner

  committed
  e2cecec

  Copy full SHA for e2cecec

• fix(sidebar): avoid whitespace: pre by wrapping highlighted text

  caugner

  committed
  b23a70d

  Copy full SHA for b23a70d

• feat(sidebar): restore scroll position after filtering

  caugner

  committed
  ba8d27c

  Copy full SHA for ba8d27c

• fix(sidebar): remove filter background

  caugner

  committed
  40b27a7

  Copy full SHA for 40b27a7

• fixup! feat(sidebar): restore scroll position after filtering

  caugner

  committed
  af1e76d

  Copy full SHA for af1e76d

• fix(sidebar): avoid filter clear button moving

  caugner

  committed
  6ab2587

  Copy full SHA for 6ab2587

• fixup! chore(sidebar): refine layout + thumbs

  caugner

  committed
  34012bb

  Copy full SHA for 34012bb

• fix(sidebar): add backdrop to filter

  caugner

  committed
  e3f255a

  Copy full SHA for e3f255a

• chore(sidebar): move thumbs below filter + add text

  caugner

  committed
  e118e6f

  Copy full SHA for e118e6f

• chore(thumbs): change how thumbs up/down behave on hover/active

  caugner

  committed
  fdb46f4

  Copy full SHA for fdb46f4

• chore(sidebar): fade thumbs unless hover/focus-within

  caugner

  committed
  02f6c0f

  Copy full SHA for 02f6c0f

• fix(sidebar): make toc non-relative

  Show description for 99a31f2
  caugner

  committed
  99a31f2

  Copy full SHA for 99a31f2

• fix(sidebar): fix glean-thumbs height

  caugner

  committed
  2d193d4

  Copy full SHA for 2d193d4

• fix(thumbs): use 0/1 for rating value

  Show description for 2e40f97
  caugner

  committed
  2e40f97

  Copy full SHA for 2e40f97

• fix(sidebar): avoid icons showing on top of the filter

  caugner

  committed
  6efe597

  Copy full SHA for 6efe597

• chore(sidebar): hide filter on mobile

  caugner

  committed
  ec60003

  Copy full SHA for ec60003

• fixup! fix(sidebar): avoid icons showing on top of the filter

  caugner

  committed
  a2569ef

  Copy full SHA for a2569ef

• Revert "chore(sidebar): fade thumbs unless hover/focus-within"

  Show description for 551eb13
  caugner

  committed
  551eb13

  Copy full SHA for 551eb13

• chore(sidebar): make filter field span full width

  caugner

  committed
  a5aa418

  Copy full SHA for a5aa418

• chore(sidebar): align thumbs right

  caugner

  committed
  6ea75e7

  Copy full SHA for 6ea75e7

• chore(sidebar): reduce filter font-size

  caugner

  committed
  192e1e0

  Copy full SHA for 192e1e0

• fix(sidebar): hide filter on medium screen as well

  caugner

  committed
  cbcd7b1

  Copy full SHA for cbcd7b1

• feat(sidebar): record sidebar_click_with_filter event

  caugner

  committed
  0f7af37

  Copy full SHA for 0f7af37

• chore(sidebar): center thumbs

  caugner

  committed
  df98cce

  Copy full SHA for df98cce

• chore(thumbs): rephrase default question

  caugner

  committed
  1c9544e

  Copy full SHA for 1c9544e

• fixup! feat(sidebar): record sidebar_click_with_filter event

  caugner

  committed
  9422238

  Copy full SHA for 9422238

• chore(sidebar): show the filter clear only if there is a value

  caugner

  committed
  5da76c3

  Copy full SHA for 5da76c3

• feat(sidebar-filter): show number of matches in footer

  caugner

  committed
  cc33088

  Copy full SHA for cc33088

• feat(sidebar-filter): show/hide section headings dynamically

  caugner

  committed
  40e9e5e

  Copy full SHA for 40e9e5e

• chore(sidebar-filter): show match count below thumbs

  caugner

  committed
  7375bfa

  Copy full SHA for 7375bfa

• chore(thumbs): refine wording

  caugner

  committed
  2618d2f

  Copy full SHA for 2618d2f

Commits on Jun 2, 2023

• fix(sidebar-filter): use --mark-color for highlights

  caugner

  committed
  0a59a41

  Copy full SHA for 0a59a41

• fix(sidebar-filter): align left width breadcrumbs

  caugner

  committed
  659b559

  Copy full SHA for 659b559

• fix(sidebar-filter): hide on pages w/o sidebar

  caugner

  committed
  a9b506c

  Copy full SHA for a9b506c

• fix(sidebar-filter): add border on focus

  caugner

  committed
  5fd075f

  Copy full SHA for 5fd075f

• fix(sidebar-filter): left align thumbs + items with filter icon

  caugner

  committed
  4679281

  Copy full SHA for 4679281

• fix(sidebar-filter): increase space between input and thumbs

  caugner

  committed
  975e294

  Copy full SHA for 975e294

• chore(sidebar-filter): use different color for match count

  caugner

  committed
  6b1a99e

  Copy full SHA for 6b1a99e

• fix(sidebar-filter): increase backdrop length + distance

  caugner

  committed
  1ba0f55

  Copy full SHA for 1ba0f55

• chore(thumbs): highlight confirmation for 5 seconds, then transition for 1 second

  caugner

  committed
  f6a37e9

  Copy full SHA for f6a37e9

• chore(thumbs): add heart emoji

  caugner

  committed
  5fc145a

  Copy full SHA for 5fc145a

• feat(sidebar-filter): collapse if no focus/value

  Show description for 0623c6e
  caugner

  committed
  0623c6e

  Copy full SHA for 0623c6e

• chore(sidebar-filter): show footer only with focus

  caugner

  committed
  27d884a

  Copy full SHA for 27d884a

• fix(sidebar): show footer upon user interaction

  caugner

  committed
  bcc4a0d

  Copy full SHA for bcc4a0d

• feat(sidebar-filter): measure when users focus the filter

  caugner

  committed
  a98d55e

  Copy full SHA for a98d55e

• feat(sidebar-filter): show count inside input field

  caugner

  committed
  cb7425f

  Copy full SHA for cb7425f

• chore(thumbs): improve animation

  caugner

  committed
  82444ba

  Copy full SHA for 82444ba

• fix(thumbs): make up/downLabel props

  caugner

  committed
  1ad51b0

  Copy full SHA for 1ad51b0

• fix(sidebar-filter): redistribute responsibilities between .sidebar-actions and .sidebar-filter

  caugner

  committed
  8306118

  Copy full SHA for 8306118

• chore(sidebar-filter): keep input open + thumbs visible until cleared

  Show description for bc611f6
  caugner

  committed
  bc611f6

  Copy full SHA for bc611f6

• fix(sidebar-filter): optimize gradient/padding to keep sidebar begin at same position

  Show description for 964d75e
  caugner

  committed
  964d75e

  Copy full SHA for 964d75e

• fix(sidebar-filter): make it available on mobile

  caugner

  committed
  42fff01

  Copy full SHA for 42fff01

• fix(sidebar-filter): align items centrally

  caugner

  committed
  92a7238

  Copy full SHA for 92a7238

• fix(sidebar): remove padding-top

  caugner

  committed
  4902f19

  Copy full SHA for 4902f19

• fixup! fix(sidebar-filter): optimize gradient/padding to keep sidebar begin at same position

  caugner

  committed
  f426b1c

  Copy full SHA for f426b1c

• fix(sidebar-filter): unset color for mark elements

  caugner

  committed
  af87710

  Copy full SHA for af87710

• chore(sidebar-filter): do not replace unrelated text nodes

  caugner

  committed
  623bdab

  Copy full SHA for 623bdab

• refactor(sidebar-filter): resolve unnecessary return

  caugner

  committed
  ab38a70

  Copy full SHA for ab38a70

• refactor(sidebar-filter): replace while with for..of

  caugner

  committed
  3688a7c

  Copy full SHA for 3688a7c

• refactor(sidebar-filter): move function behind constructor

  caugner

  committed
  719644b

  Copy full SHA for 719644b

• refactor(sidebar-filter): use querySelector instead of getElementById

  Show description for c76f4c7
  

  caugner

  and

  LeoMcA

  authored
  c76f4c7

  Copy full SHA for c76f4c7

Commits on Jun 5, 2023

• chore(sidebar-filter): hide "In this article" if no match

  caugner

  committed
  a71d6aa

  Copy full SHA for a71d6aa

• refactor(sidebar-fiilter): rename collapse{Detail => Parent}

  caugner

  committed
  e7b780f

  Copy full SHA for e7b780f

• refator(sidebar-filter): rename dataset.{open => wasOpen}

  Show description for 4a21121
  

  caugner

  and

  LeoMcA

  committed
  4a21121

  Copy full SHA for 4a21121

• chore: remove unnecessary jsdoc

  caugner

  committed
  da4979d

  Copy full SHA for da4979d

• fix(sidebar-filter): exclude + hide TOC

  caugner

  committed
  4fec9d9

  Copy full SHA for 4fec9d9

• refactor(sidebar-filter): inline SidebarFilterer.root

  caugner

  committed
  ad17162

  Copy full SHA for ad17162

• feat(thumbs): hide if previously submitted

  caugner

  committed
  7bb2c13

  Copy full SHA for 7bb2c13

• fix(sidebar-filter): remove weird icon margin

  caugner

  committed
  01aea1d

  Copy full SHA for 01aea1d

• fix(sidebar-filter): apply clear button style to thumbs buttons as well

  caugner

  committed
  dff58a7

  Copy full SHA for dff58a7

• fixup! feat(thumbs): hide if previously submitted

  caugner

  committed
  d212d75

  Copy full SHA for d212d75

• chore(sidebar-filter): align heart with clear button

  caugner

  committed
  6774799

  Copy full SHA for 6774799

Commits on Jun 6, 2023

• refactor(sidebar-filter): extract toggleElement()

  caugner

  committed
  65a2f3b

  Copy full SHA for 65a2f3b

• fix(sidebar-filter): show by resetting style.display

  Show description for 119277b
  caugner

  committed
  119277b

  Copy full SHA for 119277b

• fix(sidebar-filter): avoid forEach without this context

  caugner

  committed
  7ae26aa

  Copy full SHA for 7ae26aa

• fix(thumbs): increase gap between icons

  Show description for 0de11bf
  caugner

  committed
  0de11bf

  Copy full SHA for 0de11bf

• fix(sidebar-filter): increase icon size to 1rem/16px

  caugner

  committed
  405cd50

  Copy full SHA for 405cd50

• fix(sidebar-filter): use border-radius of 1rem

  Show description for afebb01
  caugner

  committed
  afebb01

  Copy full SHA for afebb01

• fix(sidebar-filter): align thumbs left + add margin-top to content

  Show description for 230bcb5
  caugner

  committed
  230bcb5

  Copy full SHA for 230bcb5

• chore(sidebar-filter): increase font-size

  caugner

  committed
  add9db5

  Copy full SHA for add9db5

• fix(sidebar-filter): do not resize thumbs button

  caugner

  committed
  63482e3

  Copy full SHA for 63482e3

• fix(sidebar-filter): add padding-right to avoid touching the scrollbar

  caugner

  committed
  42b3364

  Copy full SHA for 42b3364

• chore(sidebar-filter): align feedback with filter icon

  caugner

  committed
  ceda9b1

  Copy full SHA for ceda9b1

• refactor(sidebar-filter): extract getLinkContainer()

  caugner

  committed
  03ac5ea

  Copy full SHA for 03ac5ea

• refactor(sidebar-filter): extract getParents()

  caugner

  committed
  921c8f8

  Copy full SHA for 921c8f8

• refactor(sidebar-filter): extract getHeading[Container]()

  caugner

  committed
  d18edb5

  Copy full SHA for d18edb5

• perf(sidebar-filter): avoid duplicate work

  caugner

  committed
  c6a74a2

  Copy full SHA for c6a74a2

• refactor(sidebar-filter): rename all{Headings,Parents}

  caugner

  committed
  1cb333d

  Copy full SHA for 1cb333d

• refactor(sidebar-filter): merge get{Link,Heading}Container()

  caugner

  committed
  db3747a

  Copy full SHA for db3747a

• perf(sidebar-filter): reuse SidebarFilterer

  caugner

  committed
  67bcf71

  Copy full SHA for 67bcf71

• fix(sidebar-filter): store scrollTop in ref, not state

  Show description for dce2972
  caugner

  committed
  dce2972

  Copy full SHA for dce2972

• refactor(sidebar-filter): extract usePersistedScrollPosition()

  caugner

  committed
  6bdd5f5

  Copy full SHA for 6bdd5f5

• refactor(sidebar-filter): extract useSidebarFilter()

  caugner

  committed
  43d8cec

  Copy full SHA for 43d8cec

• refactor(sidebar-filter): rename {hasUserInteraction => isActive}

  caugner

  committed
  ad775ea

  Copy full SHA for ad775ea

• chore(sidebar-filter): show count only if active

  caugner

  committed
  fd71c3f

  Copy full SHA for fd71c3f

• chore(sidebar): add comment about reducing margin-top again

  Show description for f4bb33e
  caugner

  committed
  f4bb33e

  Copy full SHA for f4bb33e

• fix(sidebar-filter): avoid margin-top on mobile

  caugner

  committed
  8badf14

  Copy full SHA for 8badf14

• fix(sidebar-filter): restore scroll positon on mobile

  caugner

  committed
  06467cc

  Copy full SHA for 06467cc

• fix(sidebar-filter): hide parent container, not parent

  Show description for 3d30de5
  caugner

  committed
  3d30de5

  Copy full SHA for 3d30de5

• refactor(sidebar-filter): rename target => container

  caugner

  committed
  1255bc2

  Copy full SHA for 1255bc2

• fix(sidebar-filter): set z-index on sidebar-actions, instead of icon

  caugner

  committed
  8758bb3

  Copy full SHA for 8758bb3

• fix(sidebar-filter): disable autocomplete

  Show description for 28dea13
  caugner

  committed
  28dea13

  Copy full SHA for 28dea13

• fix(sidebar-filter): use textContent, not innerText

  Show description for c157fae
  caugner

  committed
  c157fae

  Copy full SHA for c157fae

Commits on Jun 7, 2023

• feat(sidebar-filter): color filter icon when we have input

  caugner

  committed
  6dd696e

  Copy full SHA for 6dd696e

• Merge branch 'main' into sidebar-filter

  caugner

  committed
  85d8067

  Copy full SHA for 85d8067

Commits on Jun 8, 2023

• fix(sidebar-filter): trim query

  Show description for 639407f
  caugner

  committed
  639407f

  Copy full SHA for 639407f

• chore(sidebar): remove unnecessary position: relative

  caugner

  authored
  230646f

  Copy full SHA for 230646f

• fix(sidebar-filter): assign quicklinks/sidebarInnerNav once

  Show description for 371fc5f
  caugner

  committed
  371fc5f

  Copy full SHA for 371fc5f

• chore(sidebar-filter): remove unnecessary CSS block

  Show description for d6cb3af
  caugner

  committed
  d6cb3af

  Copy full SHA for d6cb3af

• refactor(sidebar-filter): rename params for consistency

  caugner

  committed
  1cb822b

  Copy full SHA for 1cb822b

• refactor(sidebar-filter): rename functions for clarity

  caugner

  committed
  e9ce3ac

  Copy full SHA for e9ce3ac