[SER] Patch 1: HitObject type lowering and SM 6.9 enablement #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="NVIDIA" |
bob80905
reviewed
Jan 31, 2025
tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject-entry-errors.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject-in-buffer.hlsl
Outdated
Show resolved
Hide resolved
llvm-beanz
reviewed
Feb 14, 2025
llvm-beanz
reviewed
Feb 14, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
damyanp
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Note, as per microsoft/hlsl-specs#378, ReorderThread needs to be named MaybeReorderThread.
tools/clang/test/SemaHLSL/hlsl/intrinsics/ser/reorder-unclaimed-pre-sm69.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/SemaHLSL/hlsl/intrinsics/ser/reorder-unclaimed-pre-sm69.hlsl
Outdated
Show resolved
Hide resolved
llvm-beanz
reviewed
Feb 25, 2025
Reduction of the complete SER implementation to just the HitObject type and its default constructor. Specification PR: microsoft/hlsl-specs#277
When specifying more than four stages in a PAQ, the
SmallVector in the PayloadAccessAnnotation starts to allocate memory.
That memory is never free'd.
The hitobject-entry-errors accidentally triggered this:
struct [raypayload] Payload
{
float elem
- : write(caller,closesthit,anyhit,closesthit,miss)
- : read(caller,closesthit,anyhit,closesthit,miss);
+ : write(caller,anyhit,closesthit,miss)
+ : read(caller,anyhit,closesthit,miss);
};
…r codegen, use 'MOP_HitObject_MakeNop' as default ctor
HitObject-as-scalar remnants
…d remove" This reverts commit b028aaf.
…icFunctions / revert ULE shortcut for ::dx namespace
Right, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduction of the complete SER implementation to just the HitObject type and its default constructor.
This has most of the infrastructure changes in DXC to support SER, eg static member functions for builtins, HitObject scalar type.
Specification PR: microsoft/hlsl-specs#277