Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower spirv ray query type to opaque debug type #7139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChristianReinbold
Copy link
Contributor

Pull request for Issue #7033. It is still lacking a test though. If you can give me a quick pointer to a test directory where I can reformulate my reproducer as a test, I will add it as well.

Copy link
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. This is a big help. The change look go to me.

You can add a test to https://github.com/microsoft/DirectXShaderCompiler/tree/20950d662f4d24850d7edfe1e647f6749d5c13b3/tools/clang/test/CodeGenSPIRV.

You can see examples in that directory. You'll want to add your hlsl source file with a RUN line at the top, and at least one CHECK line to look for code you expect to see.

You can run the tests by running:

ninja check-clang-codegenspirv

@ChristianReinbold
Copy link
Contributor Author

ChristianReinbold commented Feb 13, 2025

I am not building with ninja right now, but have a visual studio solution. Right now I am trying to launch tests via:

hcttest file-check "src\tools\clang\test\CodeGenSPIRV\attribute.location.lib.hlsl"

but it fails at the disassembly stage due to an invalid bitcode signature. Note that the compilation process seems to succeed. Whatever I am trying to do in order to make tests work, I seem to be completely on the wrong track here. That blocks me right now. No idea where to continue the investigation.

@s-perron
Copy link
Collaborator

Sorry, I did not get back to you. Can run the tests by building the check-clang-codegenspirv target. Look for that target in visual studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants