This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add reference to Microsoft.NETCore.Platforms package to workaround A SDK issue #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/dotnet/cli/issues/12341. Remove the reference once build machine moves to .NET Core 3.0
marklio
approved these changes
Oct 21, 2019
|
The test failure is not related with this PR and has been fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a SDK issue in .NET Core 2.* (https://github.com/dotnet/cli/issues/12341). The issue results with ilasm.exe is not copied to Microsoft.Fx.Portability.MetadataReader.Tests\net461\win7-x86 output directory as it should be. Add reference to Microsoft.NETCore.Platforms package to workaround the issue. The issue has been fixed in .NET Core 3.0 SDK (verified on 3.0.100). The reference should be removed once build machine moves to .NET Core 3.0.