This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Integrate changes from dev branch to master #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add DiagnosticListener to source
so we can run various tools on just binaries that we own
* Add .NET Core App 2.1 and .NET 4.6.1 as targets * Add compiler directive for string.replace * Fix Verify DotNetFilter tests * Add FEATURE_ILASM for tests that are Windows-only * Specify RuntimeIdentifiers * Add correct references to compile for netcoreapp * Not specifying test file name because it is unnecessary * Add support for build.sh to test on netcoreapp * Run tests in one directory, ./TestResults * Checking for dotnet.exe in path first before installing * Fixing AssemblyFileComparer to be Platform cognizant * Fixing current directory if it is not the same (ie. in NET461)
* loading CompiledRazorAssemblies if they have not been loaded already. * Targeting Reports.Html for .NET 4.6.1 * Targeting Reports.Html.Tests against .NET4.6.1
to work around an issue where Portable format is not yet supported in api scanning tool(s).
* Allow TargetNameParser to parse both target identifiers and FrameworkNames (target identifiers with version). * Remove unneeded private set; * Add tests
Use string.Intern to reduce duplicates of framework names and return type names.
…Analyzer Setting are not navigatable
The HyperLinks to About and Privacy docs on Portability Analyzer Setting are not navigatable
…MemberInfo.cs To make the return collection readonly as well per mark's suggestion Co-Authored-By: Mark Miller <[email protected]>
fix MissingMemberInfo.UsedIn doesn't return anything
…NET standard1.3 support and only support .NET standard2.0; updated ApiPort console apps to .NET Core 2.1 standalone app and removed desktop app support; update VS extensions to target .net4.6.1. Also fixed some warnings to call some APIs with specific cultureInfo.
Remove out of date readme
Create nuget package at build time
Add reference to Microsoft.NETCore.Platforms package to workaround A SDK issue
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
marklio
reviewed
Oct 22, 2019
src/lib/Microsoft.Fx.Portability.MetadataReader/MemberMetadataInfo.cs
Outdated
Show resolved
Hide resolved
format fixes per CR feedback
marklio
reviewed
Oct 24, 2019
marklio
reviewed
Oct 24, 2019
marklio
suggested changes
Oct 24, 2019
Lxiamail
commented
Oct 30, 2019
src/lib/Microsoft.Fx.Portability/Utils/JsonConverters/JsonMultiDictionaryConverter.cs
Outdated
Show resolved
Hide resolved
Continue search for the remaining node when find a _searchInGraph is true. Change TryGetGetAPICountFromReferences to GetAPICountFromReferences since no needs to use the return value, the availableApis and unavailableApis values should be all needed.
marklio
approved these changes
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional improvements:
Fixed all Y11MAS accessibility issues to meet grade C requirements (#783, #792)
Make ApiPort tool to be .NET Core Global tool (#790)
Fixed DGML fails when there is unresolved dependency(#796)
Moved HTML report generator to a razor library (#742)
Added DiagnosticListener to report ServiceProvider (#745)
Update TargetNameParser to understand versions (#757)
Reports.Html works on .NET Framework (#751)
Updated the HyperLinks to About and Privacy docs on Portability Analyzer Setting are not navigable (#765)
Updated the document link in excel report (#807)
Fix Assembly name header name in Excel report (#779)
Fixed MissingMemberInfo.UsedIn doesn't return anything (#779)
Added JsonPublicKeyTokenconverter to Serialize PublicKeyToken (#800)
Fundamental improvements:
Change IReportWriter.WriteStream to be async (#743)
Don't require AssemblyReferenceInformation for IDependencyFilter to reduce memory allocation (#784)
Upgraded .NET Portability libraries from .NET Standard 1.3 to .NET Standard 2.0 (#790)
Upgraded ApiPort Console apps to .NET Core 2.1 and .NET Framework 4.6.1. Upgraded ApiPort VS extension to 4.6.1 (#790)
Set up some caching in json conversion (#785)
Engineering improvements:
Update StyleCop.Analyzers and compiler version used (#747)
Gather all our built binaries and symbols at one place (#748)
Adding support for running tests cross-platform (#746)
Fiximg LicenseUrl is deprecated warning (#750)
Use Full PDB format for net4* projects (#754)
Add reference to Microsoft.NETCore.Platforms to workaround dotnet/cli issue… (#808)