Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP - uint8, int8 serialization support #1473

Merged
merged 10 commits into from
May 25, 2022
Merged

PHP - uint8, int8 serialization support #1473

merged 10 commits into from
May 25, 2022

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Mar 31, 2022 •
edited
Loading

  • Adds mappings for sbyte and byte in the PhpConventionService
  • Updates some previous primitive type mappings

closes #1368

@Ndiritu Ndiritu requested a review from SilasKenneth March 31, 2022 09:25
@Ndiritu Ndiritu self-assigned this Mar 31, 2022
@Ndiritu Ndiritu added the PHP label Mar 31, 2022
@Ndiritu Ndiritu marked this pull request as draft March 31, 2022 09:29
@Ndiritu Ndiritu marked this pull request as ready for review March 31, 2022 09:38
baywet
baywet requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking a stab at that. I do think the type mapping is still missing entries.

@Ndiritu Ndiritu marked this pull request as draft April 14, 2022 14:15
@Ndiritu Ndiritu force-pushed the feat/php-missing-type-mappings branch from a1fdcae to c645ff8 Compare April 14, 2022 14:29
@Ndiritu Ndiritu force-pushed the feat/php-missing-type-mappings branch 2 times, most recently from 6529d9c to 26917a5 Compare April 26, 2022 10:28
@Ndiritu Ndiritu marked this pull request as ready for review April 26, 2022 10:53
@Ndiritu Ndiritu force-pushed the feat/php-missing-type-mappings branch from d614865 to 0cd4e03 Compare May 23, 2022 13:16
@Ndiritu
Copy link
Contributor Author

Ndiritu commented May 23, 2022

@baywet @SilasKenneth I've rebased my changes onto main while removing previous 32-bit support commits. Please take another look at this.

baywet
baywet previously approved these changes May 24, 2022
View reviewed changes
@baywet baywet requested a review from SilasKenneth May 24, 2022 11:45
SilasKenneth
SilasKenneth previously approved these changes May 24, 2022
View reviewed changes
@Ndiritu Ndiritu dismissed stale reviews from SilasKenneth and baywet via 7ef92a5 May 25, 2022 07:27
@Ndiritu Ndiritu requested a review from baywet May 25, 2022 07:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Ndiritu Ndiritu requested a review from SilasKenneth May 25, 2022 07:32
@baywet baywet merged commit fcbcad7 into main May 25, 2022
@baywet baywet deleted the feat/php-missing-type-mappings branch May 25, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@SilasKenneth SilasKenneth SilasKenneth approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees

@Ndiritu Ndiritu

Labels
PHP
Projects
None yet
Milestone
Complete Graph API Surface support
Development

Successfully merging this pull request may close these issues.

php - implement uint8 int8 and float128 support for serialization
3 participants
@Ndiritu @baywet @SilasKenneth