PHP - uint8, int8 serialization support

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 ### Added
+- Added missing mappings in PHP for uint8 and int8. [#1473](https://github.com/microsoft/kiota/pull/1473)
 
 ### Changed
 

abstractions/php/src/Serialization/ParseNode.php

@@ -5,7 +5,6 @@
 use DateInterval;
 use DateTime;
 use Microsoft\Kiota\Abstractions\Enum;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Psr\Http\Message\StreamInterface;
@@ -93,18 +92,6 @@ public function getTimeValue(): ?Time;
      */
     public function getEnumValue(string $targetEnum): ?Enum;
 
-    /**
-     * @param string $targetClass
-     * @return Enum[]|null
-     */
-    public function getCollectionOfEnumValues(string $targetClass): ?array;
-
-    /**
-     * Return a byte value.
-     * @return Byte|null
-     */
-    public function getByteValue(): ?Byte;
-
     /**
      * Get a Stream from node.
      * @return StreamInterface|null

abstractions/php/src/Serialization/SerializationWriter.php

@@ -4,7 +4,6 @@
 use DateInterval;
 use DateTime;
 use Microsoft\Kiota\Abstractions\Enum;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Psr\Http\Message\StreamInterface;
@@ -122,13 +121,6 @@ public function writeTimeValue(?string $key, ?Time $value): void;
      * @return void
      */
     public function writeDateIntervalValue(?string $key, ?DateInterval $value): void;
-    /**
-     * Write a byte value.
-     * @param string|null $key
-     * @param Byte|null $value
-     * @return void
-     */
-    public function writeByteValue(?string $key, ?Byte $value): void;
 
     /**
      * @param string|null $key

serialization/php/json/composer.json

@@ -12,7 +12,10 @@
   "repositories": [
     {
       "type": "path",
-      "url": "../../../abstractions/php"
+      "url": "../../../abstractions/php",
+      "options": {
+        "symlink": false
+      }
     }
   ],
   "autoload": {

serialization/php/json/src/JsonParseNode.php

@@ -11,7 +11,6 @@
 use Microsoft\Kiota\Abstractions\Serialization\AdditionalDataHolder;
 use Microsoft\Kiota\Abstractions\Serialization\Parsable;
 use Microsoft\Kiota\Abstractions\Serialization\ParseNode;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Psr\Http\Message\StreamInterface;
@@ -238,8 +237,6 @@ public function getAnyValue(string $type) {
                 return $this->getDateValue();
             case Time::class:
                 return $this->getTimeValue();
-            case Byte::class:
-                return $this->getByteValue();
             default:
                 if (is_subclass_of($type, Enum::class)){
                     return $this->getEnumValue($type);
@@ -268,13 +265,6 @@ public function getTimeValue(): ?Time {
         return ($this->jsonNode !== null) ? new Time($this->jsonNode) : null;
     }
 
-    /**
-     * @inheritDoc
-     */
-    public function getByteValue(): ?Byte {
-        return ($this->jsonNode !== null) ? new Byte($this->jsonNode) : null;
-    }
-
     /**
      * @inheritDoc
      * @throws Exception

serialization/php/json/src/JsonSerializationWriter.php

@@ -333,9 +333,6 @@ public function writeAnyValue(?string $key, $value): void{
             case Time::class:
                 $this->writeTimeValue($key, $value);
                 break;
-            case Byte::class:
-                $this->writeByteValue($key, $value);
-                break;
             case DateTime::class:
                 $this->writeDateTimeValue($key, $value);
                 break;
@@ -464,19 +461,4 @@ public function writeDateIntervalValue(?string $key, ?DateInterval $value): void
             $this->writePropertyValue($key, $val);
         }
     }
-
-    /**
-     * @inheritDoc
-     */
-    public function writeByteValue(?string $key, ?Byte $value): void {
-
-
-        if ($value !== null) {
-            if (!empty($key)) {
-                $this->writePropertyName($key);
-            }
-            $val = (int)(string)($value);
-            $this->writePropertyValue($key, $val);
-        }
-    }
 }

serialization/php/json/tests/JsonParseNodeTest.php

@@ -8,7 +8,6 @@
 use GuzzleHttp\Psr7\Utils;
 use Microsoft\Kiota\Abstractions\Enum;
 use Microsoft\Kiota\Abstractions\Serialization\ParseNode;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Microsoft\Kiota\Serialization\Json\JsonParseNode;
@@ -95,16 +94,6 @@ public function testGetAnyValue(): void {
         $this->assertEquals('Silas Kenneth', $expectedString);
     }
 
-    public function testGetByteValue(): void {
-        $this->parseNode = new JsonParseNode('23');
-        $expected = $this->parseNode->getByteValue();
-        $this->assertInstanceOf(Byte::class, $expected);
-        $this->assertEquals(23, (string)$expected);
-        $this->expectException(Exception::class);
-        $this->parseNode = new JsonParseNode('-192');
-        $this->parseNode->getByteValue();
-    }
-
     public function testGetEnumValue(): void {
         $this->parseNode = new JsonParseNode('married');
         /** @var Enum $expected */

serialization/php/json/tests/JsonSerializationWriterTest.php

@@ -3,7 +3,6 @@
 namespace Microsoft\Kiota\Serialization\Tests;
 
 use Microsoft\Kiota\Abstractions\Serialization\SerializationWriter;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Microsoft\Kiota\Serialization\Json\JsonSerializationWriter;
@@ -135,9 +134,9 @@ public function testWriteEnumValue(): void{
 
     public function testWriteAnyValue(): void {
         $this->jsonSerializationWriter = new JsonSerializationWriter();
-        $byte = new Byte(23);
-        $this->jsonSerializationWriter->writeAnyValue("to", $byte);
-        $expected = '"to":23';
+        $time = new Time('11:00:00');
+        $this->jsonSerializationWriter->writeAnyValue("created", $time);
+        $expected = '"created":"11:00:00"';
         $actual = $this->jsonSerializationWriter->getSerializedContent()->getContents();
         $this->assertEquals($expected, $actual);
     }
@@ -198,17 +197,6 @@ public function testGetSerializedContent(): void{
         $this->assertEquals($expected, $actual);
     }
 
-    /**
-     */
-    public function testWriteByteValue(): void{
-        $this->jsonSerializationWriter = new JsonSerializationWriter();
-        $byte = new Byte(23);
-        $this->jsonSerializationWriter->writeAnyValue("to", $byte);
-        $expected = '"to":23';
-        $actual = $this->jsonSerializationWriter->getSerializedContent()->getContents();
-        $this->assertEquals($expected, $actual);
-    }
-
     /**
      */
     public function testWriteStringValue(): void {

src/Kiota.Builder/Writers/Php/PhpConventionService.cs

@@ -60,8 +60,9 @@ public override string TranslateType(CodeType type)
             return typeName?.ToLowerInvariant() switch
             {
                 "boolean" => "bool",
-                "double" or "decimal" => "float",
-                "integer" or "int32" or "int64" => "int",
+                "double" => "float",
+                "decimal" or "byte" => "string",
+                "integer" or "int32" or "int64" or "sbyte" => "int",
                 "object" or "string" or "array" or "float" or "void" => typeName.ToLowerInvariant(),
                 "binary" => "StreamInterface",
                 _ => typeName.ToFirstCharacterUpperCase()