Let users pick from installed debuggers before sending them to the Marketplace

[weinand]

Simulate the scenario:

user has an installed debugger (that wasn't updated to include a "language" contribution) by pressing F5 on a single file and without a launch.json

with these steps:

• use Mock debug project
• remove the "languages": ["markdown"], contribution from package.json
• launch Mock debug with F5
• in new window remove the .vscode/launch.json
• open test.md
• press F5

Observe:

Previously we would get the "debug environment" Quickpick in this situation (which IMO makes more sense).

I suggest the following:

• as a fallback use the breakpoints contribution in a debugger's package.json as a strong indication for whether the debugger can handle the file type, and if that doesn't help
• show a debugger Quickpick to let the user select one of his debugger extensions, and only if there is none let the user search on the Marketplace (IIRC this is more or less the old behavior).

[isidorn]

I like your idea to use the breakpoints as hint.
So I went with that, in short:

• if we can set breakpoints in the current file we behave as before (show a debugger Quickpick)
• If we can not -> we have the new "Marketplace" dialog (in this case I do not want to show the quick pick first to make the flow simple)

Try it out and let me know what you think. Thanks

[connor4312]

Hmm, I followed Andre's suggested steps:

1. Installed mock debug
2. Removed the languages from its package.json
3. Reloaded, verified I could set breakpoints, F5'd, then got this dialog:

Am I doing something differently?

[isidorn]

@connor4312 good catch, your steps are great. I made a rookie mistake. Pushed a fix and verified it is good now. Thanks!