Revert "Update C# grammar" that introduces invalid grammar #132400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once dotnet/csharp-tmLanguage#220 is merged, it would be better to update again instead. |
|
@alexr00 Hi Alex, hope this can be fixed soon so I can continue to use shiki to highlight C#. |
|
Didn't realize that would happen, makes sense I guess... the revert is no longer necessary, an update would be better |
|
Just updated the grammar. Thanks for bringing this up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bd24934.
The reverted commit contains the regular expression
(?<!\?\s*)\?(?!\?|\.|\[), which is an invalid regular expression because the lookbehind is no longer fixed width.