The auto-updated csharp language has an issue with OnigScanner

[orta]

https://github.com/shikijs/shiki/pull/218/checks?check_run_id=3497151928#step:10:10

  ● validates all languages can show a hello-world › csharp

    105,110,118,97,108,105,100,32,112,97,116,116,101,114,110,32,105,110,32,108,111,111,107,45,98,101,104,105,110,100
     |     let result = grammar.tokenizeLine2(line, ruleStack)
     |     let tokensLength = result.tokens.length / 2
     |     for (let j = 0; j < tokensLength; j++) {

      at OnigScanner.findNextMatchSync (node_modules/onigasm/src/OnigScanner.ts:129:27)
      at node_modules/vscode-textmate/release/webpack:/vscodetextmate/out/grammar.js:586:26
      at lineTokens (node_modules/vscode-textmate/release/webpack:/vscodetextmate/out/grammar.js:537:5)
      at f (node_modules/vscode-textmate/release/webpack:/vscodetextmate/out/grammar.js:706:13)

[Gerrit0]

Of course, I didn't see this until now... more info:

"105,110,118,97,108,105,100,32,112,97,116,116,101,114,110,32,105,110,32,108,111,111,107,45,98,101,104,105,110,100"
.split(",").map(c => String.fromCharCode(+c)).join("")

Gives the error, "invalid pattern in look-behind"

• Pull request to "fix" this - Revert "Update C# grammar" that introduces invalid grammar microsoft/vscode#132400
• Pull request which originally introduced this - Allow spaces in null conditional classification dotnet/csharp-tmLanguage#216

[octref]

Good catch. Let's point to an old version for now to make master green. I subscribed to the upstream issue so once this is fixed I'll upgrade to latest.

[octref]

Let's track the dotnet one for latest C# grammar. Master is green again!

[srmagura]

Just wanted to point out two things, which you may already be aware of 😅

1. This error is affecting the latest version of shiki that's published on npm (0.9.11), not just master.
2. This error also affects the razor language, which makes sense since Razor is based on C#.

Code that produces the error (with shiki 0.9.11):

const shiki = require("shiki");

shiki
  .getHighlighter({
    theme: "nord",
  })
  .then((highlighter) => {
    console.log(
      highlighter.codeToHtml(
        `
using (var sha256 = SHA256.Create())
{
}
`,
        "razor"
      )
    );
  });

[zoubingwu]

May I ask when will there be a 0.9.12 release? my current blog build is broken with csharp code 😢

[orta]

thanks for the ping, I missed that PR